-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ATmega128RFA1 #68
Conversation
This change is a WIP now, but I'm uploading it to get some initial feedback. I'm planning to also implement Smart Response XE BSP for modm itself. |
Oh wow, I didn't know about this, there are a lot of cool projects that use this device! You did it exactly how I would've done it with the patch, great! But it's still missing some more signals, right? (The CI wants you to synchronize docs: |
Thanks! Yes, most of the signals are still missing. I'm adding them one by one and trying to test on the hardware or at least check if it builds. Then I'll do a final pass comparison between mega128A and this chip to make sure if there's nothing else I missed. I only had one trouble with filling blanks in the atdf file: a lot of non-GPIO pins (primarily power pins, but also e.g. |
The analog/power pins are not relevant for the HAL generation of modm, so you can leave them out. Only the ports/pins and signals are used by modm. I added the packages for projects like |
I filled all the remaining signals (except the ones not supported by modm, primarily RF) and cross-checked the output xml with datasheet. I am also quite confident about non-GPIO pins so I'll leave them in in case some other tool ever uses them. This change is ready for review. Once it's in, I'll push a corresponding change to modm to re-enable this chip and fix one clock quirk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Thanks! Should I wait with merging for the other PR, or submit this first? |
No, I just got distracted and forgot to actually merge… |
While the MCU itself isn't terribly fascinating, one of the devices using it is.
Smart Response XE is an obsolete classroom clicker, sold on eBay for ~$5 and available in large quantities. It's a compelling platform that's fully reverse engineered and ready to hack out of box: