Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Modrinth app exports shaderpacks and unwanted mods despite explicitly unchecking them during export. #754

Closed
TheD0ct0r101 opened this issue Sep 18, 2023 · 3 comments · Fixed by #789

Comments

@TheD0ct0r101
Copy link

I'm hoping its not just me experiencing this, but basically in the window where it allows me to select what folders/files I am exporting to a .mrpack file, I would uncheck the shaderpack folder as well as any clientside mods I dont feel need to be in the official modpack release. However upon uploading the .mrpack to modrinth, those shaderpacks/mods that I unchecked during the export process are just there in the file anyway.

@TheD0ct0r101 TheD0ct0r101 changed the title Bug: Modrinth exports shaderpacks and unwanted mods despite explicitly unchecking them during export. Bug: Modrinth app exports shaderpacks and unwanted mods despite explicitly unchecking them during export. Sep 18, 2023
@GeraldTM
Copy link

That might just be excluding them from overrides?

@TheD0ct0r101
Copy link
Author

To clarify, the window is worded like this:
image

unchecking a folder should exclude it from being included in the export entirely, full-stop. But weirdly this doesnt seem to be the case with unchecking shaderpacks or individual mods.

@GeraldTM
Copy link

yes, as far is I'm aware, this checkbox is for specifying files not hosted on modrinth, or specific files (eg configs) you want to be installed for the user. them mods themselves are not shipped out directly in the pack, but a link of sorts is stored in the modrinth.index.json

Geometrically pushed a commit that referenced this issue Jul 4, 2024
Co-authored-by: Prospector <prospectordev@gmail.com>
Geometrically pushed a commit that referenced this issue Oct 16, 2024
* moved files

* moved files

* initial v3 additions

* moves req data

* tests passing, restructuring, remove v2

* fmt; clippy; prepare

* merge conflicts + issues

* merge conflict, fmt, clippy, prepare

* revs

* fixed failing test

* fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants