Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make export selection consistent between platforms and allow selecting which projects to export #789

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

OmegaJak
Copy link
Contributor

@OmegaJak OmegaJak commented Oct 5, 2023

Fixes #754

There was previously a difference between Windows and the other platforms. It would appear that you could deselect exporting of mods during modpack export on Windows, while Linux and Mac wouldn't get those options. Now all platforms have the option to deselect exporting of mods/shaderpacks/whatever and it works as expected.

@OmegaJak OmegaJak changed the title DRAFT Experimenting with tests Make export selection consistent between platforms and allow selecting which projects to export Oct 6, 2023
@OmegaJak OmegaJak marked this pull request as ready for review October 6, 2023 16:03
@Geometrically Geometrically merged commit 772597c into master Oct 9, 2023
3 of 7 checks passed
@Geometrically Geometrically deleted the all_pack_components_optional branch October 9, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Modrinth app exports shaderpacks and unwanted mods despite explicitly unchecking them during export.
3 participants