-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use styled-components as shared #56
Comments
@smelukov ok fix it tonight |
@smelukov can you also try reproducing this in the latest. I added MUI demo with styled components. it will be useful to see how this issue reveals itself in that case. |
Reproduction example uses the latest version of plugin |
what I mean, there is already an example with styled components. Can you try do reproducation with them. Is it just adding styled-component to shared, or there is something else as well? |
thanks, I probably know the cause of this problem |
@husayt just add styled components into shared |
@zhangHongEn I am not sure if this is fixed. I still get
|
@husayt I tried but couldn't reproduce it. It may not be the same issue |
* feat: new plugin configuration (#28) * init ts (#29) * fix: tsconfig * fix: issues 2 3 * feat: rust demo build and preview --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: support runtime plugins (#30) Co-authored-by: Sergey Melukov <s.melukov@vk.team> * fix: Ensure @module-federation/runtime singleton (#31) * fix: Ensure @module-federation/runtime singleton * fix: build preview --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: add packageManager * fix: remoteEntry support hash; format dynamic es module (#35) * 1.0.0-alpha-7c3ba59 * fix: remove default export (#37) * fix: remove pkg-pr-new * chore: add PR title check * 1.0.0-alpha-ffc6e23 * fix: #36 and dynamic import (#38) * fix: dynamic import * fix: #36 * 1.0.0-alpha-54ad191 * 1.0.0-alpha-80b7215 * fix: #39 #44 #45 (#46) * fix: pre-bunding * feat: add pre-bunding subdependencies demo * fix: exposes . * fix: remotes support namespace * 1.0.0-alpha-4a73cd4 * fix: windows remoteEntry error (#48) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: updated examples (#50) * 1.0.0-alpha-def937d * fix updated examples (#51) * fix: #47 (#53) * 1.0.0-alpha-10e1f83 * improved examples with MUI and etc (#55) * fix: #56 #41 (#58) * 1.0.0-alpha-6cae9ab * mfruntime update and new examples (#62) * fix: #61 (#63) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-51eeeb6 * feat: shared-slash (#67) * feat: shared slash * feat: shared slash * feat: preview examples * feat: remove an-empty-js-file * fix: remove console * optimization: reduce dev mode page reload * Optimize code and comments * fix: 64 * fix: only slash --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-f87d7d3 * fix: nx #40 (#69) * 1.0.0-alpha-661e052 * fix: #68 (#71) * fix: #68 * fix: #68 * fix: windows Multi-Pack * Optimization: Reduce file writing * Optimization: code format * fix: support nx monorepo --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-1aa30c0 * fix: monorepo (#72) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: add Nuxt example (#75) * Add Nuxt host example * Gitignore generated .__mf__win folder --------- Co-authored-by: David Sellén <david.sellen@bolagsverket.se> Co-authored-by: David Sellén <david.sellen@gmail.com> * chore: update module federation and more examples (#81) * fix: #78 (#79) * fix: #78 * Update src/utils/normalizeOptimizeDeps.ts Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> * fix: #77 (#82) * 1.0.0-alpha-2f53b4e * docs: update Vue example link * docs: update React example link * docs: update README * fix: Remote virtual module path (#84) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-c13dc95 * feat: add improvements (#86) * fix: Remote virtual module path * examples: nuxt(Unfinished) * feat: mf-manifest; Register remote on demand * doc: roadmap * doc: npm url * Delete src/utils/getLocalSharedImportMap_windows.ts --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> --------- Co-authored-by: zhn <zhang_h_n@163.com> Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> Co-authored-by: Sergey Melukov <s.melukov@vk.team> Co-authored-by: HG <husayt@gmail.com> Co-authored-by: David sellén <sellen.david@gmail.com> Co-authored-by: David Sellén <david.sellen@bolagsverket.se> Co-authored-by: David Sellén <david.sellen@gmail.com>
@zhangHongEn
Bug reproduction is here (repro-branch)
Just start vite-host and vite-remote
If styled-components is not shared, then all is fine
The text was updated successfully, but these errors were encountered: