feat: new plugin configuration #28

zhangHongEn · 2024-07-24T03:44:01Z

No description provided.

timdamen · 2024-07-24T10:56:34Z

Looks great @zhangHongEn, the vite example is building and running fine. Only I'm not sure how to instead of console logging the remote components, display them on the screen. Could you provide an example of it?

gioboa · 2024-07-24T11:22:32Z

Thanks @zhangHongEn for your contribution.

zhangHongEn · 2024-07-24T16:37:29Z

Looks great @zhangHongEn, the vite example is building and running fine. Only I'm not sure how to instead of console logging the remote components, display them on the screen. Could you provide an example of it?
@timdamen Already ok

gioboa · 2024-07-29T20:25:01Z

That's a great piece of code 👏
I'm wondering if we can include module-federation-vite code inside the repository rather than using the dependency (see image below)

zhangHongEn · 2024-07-30T04:44:29Z

@gioboa 6080943

husayt · 2024-07-30T09:59:10Z

packages/examples-rust/dist/@mf-types.d.ts

@zhangHongEn do we need to include dist folder here?

Demo output, no effect

husayt · 2024-07-30T10:07:13Z

@gioboa would still be good to include your original native-federation wrapper under either /module-federation/vite/packages/native-federation or /module-federation/native-federation once this merged. This repo will have best of both worlds literally then: Module Federation for vite and Native Federation for Vite.

Thank you

gioboa · 2024-07-30T10:18:45Z

@gioboa would still be good to include your original native-federation wrapper under either /module-federation/vite/packages/native-federation or /module-federation/native-federation once this merged. This repo will have best of both worlds literally then: Module Federation for vite and Native Federation for Vite.

Thank you

The current implementation is not working with the latest esbuild updates though.
Drop the old code sounds correct to me.

gioboa · 2024-07-30T10:28:57Z

@zhangHongEn thanks for rocking with this PR. I'm wondering if we can use
'@module-federation/esbuild' code in this implementation? #27 tried to implement the functionality but it's abandoned I guess

zhangHongEn · 2024-07-30T10:37:08Z

@zhangHongEn thanks for rocking with this PR. I'm wondering if we can use '@module-federation/esbuild' code in this implementation? #27 tried to implement the functionality but it's abandoned I guess

Vite's temporary dev mode uses esbuild. I have tried configuring @module-federation/esbuild in vite.config.js optimizeDeps.esbuildOptions.plugins, but it seems to conflict with vite's pre-built

husayt · 2024-07-30T11:38:50Z

@zhangHongEn thanks for rocking with this PR. I'm wondering if we can use '@module-federation/esbuild' code in this implementation? #27 tried to implement the functionality but it's abandoned I guess

While it might be useful to look into https://www.npmjs.com/package/@module-federation/esbuild?activeTab=code this for reference, I would not recommend using that library as Vite wraps esbuild/rollup and tries to provide unified interface, so best approach to use vite holistically.

zhangHongEn · 2024-07-30T11:48:04Z

@zhangHongEn thanks for rocking with this PR. I'm wondering if we can use '@module-federation/esbuild' code in this implementation? #27 tried to implement the functionality but it's abandoned I guess

While it might be useful to look into https://www.npmjs.com/package/@module-federation/esbuild?activeTab=code this for reference, I would not recommend using that library as Vite wraps esbuild/rollup and tries to provide unified interface, so best approach to use vite holistically.

Yes, the vite plugin and esbuild plugin are independent of each other

husayt · 2024-07-31T11:27:37Z

@gioboa is there anything else blocking this PR's merge. Will be great to get this out to keep momentum on.

README.md

husayt · 2024-07-30T10:12:59Z

package.json

+    "build": "npx -y npm-run-all --parallel build:examples-vite build:examples-rust",
+    "preview": "cd packages/examples-vite && npm run preview"
+  },
+  "author": {


@zhangHongEn at least you should have your name under

"contributors": []

This is great effort and needs to be recognised. Thank you

Thank you for your recognition

gioboa · 2024-07-31T12:26:37Z

@husayt this is a good POC, but I can't release a new version of the library with this code.
I'll try to adapt this code to and cut a new release.
I also need to convert most of the files to TypeScript because right now are in pure JavaScript.

I tried to use this code and the module-federation-vite package too in this repo vue-microfrontend-demo but I can't get it to work.
@zhangHongEn Can you open a PR in that repo to show me how replace the old code with the new one pls?

zhangHongEn · 2024-07-31T16:06:40Z

@husayt this is a good POC, but I can't release a new version of the library with this code. I'll try to adapt this code to and cut a new release. I also need to convert most of the files to TypeScript because right now are in pure JavaScript.

I tried to use this code and the module-federation-vite package too in this repo vue-microfrontend-demo but I can't get it to work. @zhangHongEn Can you open a PR in that repo to show me how replace the old code with the new one pls?

It's a good test scenario indeed.
gioboa/vue-microfrontend-demo#8

gioboa · 2024-07-31T21:32:38Z

gioboa/vue-microfrontend-demo#8

Thanks 🚀

zhangHongEn · 2024-08-01T02:18:37Z

@gioboa
Please create a new branch and merge the code first. I have received some issues and PRs and need to synchronize the code.
Please give me permission so that I can quickly merge in the new non-trunk branch. Before the complete merge, I will publish the npm module-federation-vite package for use

zhangHongEn/module-federation-vite#4

gioboa · 2024-08-01T08:04:03Z

gioboa/vue-microfrontend-demo#8

Thanks 🚀

Thanks for your commitment.
I tested your PR in the Vue mfe example and it's not working, I have multiple errors during the build process.
I would like to have a fully working application here -> gioboa/vue-microfrontend-demo#8
before going on with this new implementation.

zhangHongEn · 2024-08-01T08:40:54Z

gioboa/vue-microfrontend-demo#8

Thanks 🚀

Thanks for your commitment. I tested your PR in the Vue mfe example and it's not working, I have multiple errors during the build process. I would like to have a fully working application here -> gioboa/vue-microfrontend-demo#8 before going on with this new implementation.

Done, this is not a plugin issue, but I will fix it in the plugin

 manualChunks(id) {
  if (id.indexOf("/@module-federation/runtime") > -1) {
    return "mfruntime";
  }
}

zhangHongEn · 2024-08-01T10:36:38Z

@gioboa Please create a new branch and merge the code first. I have received some issues and PRs and need to synchronize the code. Please give me permission so that I can quickly merge in the new non-trunk branch. Before the complete merge, I will publish the npm module-federation-vite package for use

zhangHongEn/module-federation-vite#4

@gioboa Can we create a new non-main branch and work together first?

gioboa · 2024-08-01T13:11:09Z

I created a new-config branch

husayt · 2024-08-01T16:18:13Z

I created a new-config branch

@zhangHongEn you can create a new PR for follow up changes.

But here are some fixes which would save you time

in pnpm-workspace.yaml

packages:
  - 'examples/*'
  - '.'

Replace 'module-federation-vite' to '@module-federation/vite' everywhere

Replace import path from 'path'; to import {join} from 'path';

remove export default federation; as only named export should be there

and still I couldn't get new-config branch working for me

zhangHongEn · 2024-08-01T17:01:50Z

@husayt #29

luokuning · 2024-08-28T06:52:52Z

@zhangHongEn Awesome! Do we need to publish a new version and update doc to provide the latest configuration?

zhangHongEn · 2024-08-28T07:05:28Z

@zhangHongEn Awesome! Do we need to publish a new version and update doc to provide the latest configuration?

I will solve these two important problems tonight. #66 #40
Currently still publishing @module-federation/vite@next to npm

luokuning · 2024-08-28T07:43:18Z

@zhangHongEn Thank you for your effort! Looking forward to the release of version 1.0.

* feat: new plugin configuration (#28) * init ts (#29) * fix: tsconfig * fix: issues 2 3 * feat: rust demo build and preview --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: support runtime plugins (#30) Co-authored-by: Sergey Melukov <s.melukov@vk.team> * fix: Ensure @module-federation/runtime singleton (#31) * fix: Ensure @module-federation/runtime singleton * fix: build preview --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: add packageManager * fix: remoteEntry support hash; format dynamic es module (#35) * 1.0.0-alpha-7c3ba59 * fix: remove default export (#37) * fix: remove pkg-pr-new * chore: add PR title check * 1.0.0-alpha-ffc6e23 * fix: #36 and dynamic import (#38) * fix: dynamic import * fix: #36 * 1.0.0-alpha-54ad191 * 1.0.0-alpha-80b7215 * fix: #39 #44 #45 (#46) * fix: pre-bunding * feat: add pre-bunding subdependencies demo * fix: exposes . * fix: remotes support namespace * 1.0.0-alpha-4a73cd4 * fix: windows remoteEntry error (#48) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: updated examples (#50) * 1.0.0-alpha-def937d * fix updated examples (#51) * fix: #47 (#53) * 1.0.0-alpha-10e1f83 * improved examples with MUI and etc (#55) * fix: #56 #41 (#58) * 1.0.0-alpha-6cae9ab * mfruntime update and new examples (#62) * fix: #61 (#63) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-51eeeb6 * feat: shared-slash (#67) * feat: shared slash * feat: shared slash * feat: preview examples * feat: remove an-empty-js-file * fix: remove console * optimization: reduce dev mode page reload * Optimize code and comments * fix: 64 * fix: only slash --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-f87d7d3 * fix: nx #40 (#69) * 1.0.0-alpha-661e052 * fix: #68 (#71) * fix: #68 * fix: #68 * fix: windows Multi-Pack * Optimization: Reduce file writing * Optimization: code format * fix: support nx monorepo --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-1aa30c0 * fix: monorepo (#72) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * feat: add Nuxt example (#75) * Add Nuxt host example * Gitignore generated .__mf__win folder --------- Co-authored-by: David Sellén <david.sellen@bolagsverket.se> Co-authored-by: David Sellén <david.sellen@gmail.com> * chore: update module federation and more examples (#81) * fix: #78 (#79) * fix: #78 * Update src/utils/normalizeOptimizeDeps.ts Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> * fix: #77 (#82) * 1.0.0-alpha-2f53b4e * docs: update Vue example link * docs: update React example link * docs: update README * fix: Remote virtual module path (#84) Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> * 1.0.0-alpha-c13dc95 * feat: add improvements (#86) * fix: Remote virtual module path * examples: nuxt(Unfinished) * feat: mf-manifest; Register remote on demand * doc: roadmap * doc: npm url * Delete src/utils/getLocalSharedImportMap_windows.ts --------- Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> --------- Co-authored-by: zhn <zhang_h_n@163.com> Co-authored-by: 张洪恩 <zhanghongen@bwcj.com> Co-authored-by: Sergey Melyukov <s.melukov@gmail.com> Co-authored-by: Sergey Melukov <s.melukov@vk.team> Co-authored-by: HG <husayt@gmail.com> Co-authored-by: David sellén <sellen.david@gmail.com> Co-authored-by: David Sellén <david.sellen@bolagsverket.se> Co-authored-by: David Sellén <david.sellen@gmail.com>

implement vite

408a449

zhangHongEn mentioned this pull request Jul 24, 2024

Whats different with originjs/vite-plugin-federation #4

Closed

张洪恩 added 3 commits July 24, 2024 23:58

vite host demo

334f10a

vite host demo

9284a5c

vite host demo

90634d6

张洪恩 and others added 3 commits July 25, 2024 01:50

vite host demo

33e2244

fix windows path

d8a6547

roadmap

eb6d1fe

zhangHongEn force-pushed the vite-implement branch from 70112cc to eb6d1fe Compare July 25, 2024 02:52

zhangHongEn force-pushed the vite-implement branch from ca2e37a to e5e37ec Compare July 30, 2024 04:43

remove npm deps

6080943

zhangHongEn force-pushed the vite-implement branch from e5e37ec to 6080943 Compare July 30, 2024 04:48

husayt reviewed Jul 30, 2024

View reviewed changes

zhangHongEn added 2 commits July 30, 2024 18:01

delete dist

74f9aa0

delete dist

01355f9

husayt approved these changes Jul 31, 2024

View reviewed changes

zhangHongEn added 2 commits August 1, 2024 14:08

feat: to typescript

065584f

feat: to typescript

f7b41b3

gioboa changed the base branch from main to new-config August 1, 2024 12:59

refactor: clean up project structure

75bf638

gioboa approved these changes Aug 1, 2024

View reviewed changes

gioboa changed the title ~~implement vite~~ feat: new plugin configuration Aug 1, 2024

gioboa merged commit 8dfd32c into module-federation:new-config Aug 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new plugin configuration #28

feat: new plugin configuration #28

zhangHongEn commented Jul 24, 2024

timdamen commented Jul 24, 2024 •

edited

Loading

gioboa commented Jul 24, 2024

zhangHongEn commented Jul 24, 2024 •

edited

Loading

gioboa commented Jul 29, 2024

zhangHongEn commented Jul 30, 2024 •

edited

Loading

husayt Jul 30, 2024

zhangHongEn Jul 30, 2024

husayt commented Jul 30, 2024

gioboa commented Jul 30, 2024

gioboa commented Jul 30, 2024

zhangHongEn commented Jul 30, 2024

husayt commented Jul 30, 2024

zhangHongEn commented Jul 30, 2024

husayt commented Jul 31, 2024

husayt Jul 30, 2024

zhangHongEn Jul 31, 2024

gioboa commented Jul 31, 2024 •

edited

Loading

zhangHongEn commented Jul 31, 2024

gioboa commented Jul 31, 2024

zhangHongEn commented Aug 1, 2024 •

edited

Loading

gioboa commented Aug 1, 2024

zhangHongEn commented Aug 1, 2024

zhangHongEn commented Aug 1, 2024

gioboa commented Aug 1, 2024

husayt commented Aug 1, 2024 •

edited

Loading

zhangHongEn commented Aug 1, 2024

luokuning commented Aug 28, 2024

zhangHongEn commented Aug 28, 2024 •

edited

Loading

luokuning commented Aug 28, 2024

feat: new plugin configuration #28

feat: new plugin configuration #28

Conversation

zhangHongEn commented Jul 24, 2024

timdamen commented Jul 24, 2024 • edited Loading

gioboa commented Jul 24, 2024

zhangHongEn commented Jul 24, 2024 • edited Loading

gioboa commented Jul 29, 2024

zhangHongEn commented Jul 30, 2024 • edited Loading

husayt Jul 30, 2024

Choose a reason for hiding this comment

zhangHongEn Jul 30, 2024

Choose a reason for hiding this comment

husayt commented Jul 30, 2024

gioboa commented Jul 30, 2024

gioboa commented Jul 30, 2024

zhangHongEn commented Jul 30, 2024

husayt commented Jul 30, 2024

zhangHongEn commented Jul 30, 2024

husayt commented Jul 31, 2024

husayt Jul 30, 2024

Choose a reason for hiding this comment

zhangHongEn Jul 31, 2024

Choose a reason for hiding this comment

gioboa commented Jul 31, 2024 • edited Loading

zhangHongEn commented Jul 31, 2024

gioboa commented Jul 31, 2024

zhangHongEn commented Aug 1, 2024 • edited Loading

gioboa commented Aug 1, 2024

zhangHongEn commented Aug 1, 2024

zhangHongEn commented Aug 1, 2024

gioboa commented Aug 1, 2024

husayt commented Aug 1, 2024 • edited Loading

zhangHongEn commented Aug 1, 2024

luokuning commented Aug 28, 2024

zhangHongEn commented Aug 28, 2024 • edited Loading

luokuning commented Aug 28, 2024

timdamen commented Jul 24, 2024 •

edited

Loading

zhangHongEn commented Jul 24, 2024 •

edited

Loading

zhangHongEn commented Jul 30, 2024 •

edited

Loading

gioboa commented Jul 31, 2024 •

edited

Loading

zhangHongEn commented Aug 1, 2024 •

edited

Loading

husayt commented Aug 1, 2024 •

edited

Loading

zhangHongEn commented Aug 28, 2024 •

edited

Loading