HGNC-related updates & skos:exactMatch -> oboInOwl:hasExactSynonym
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 12, 2022
joeflack4
changed the title
oboInOwl:hasExactSynonym -> skos:exactMatchskos:exactMatch -> oboInOwl:hasExactSynonym
joeflack4
force-pushed
the
hgnc-mappings-and-skosExactMatch
branch
from
565da4b
to
a369e6b
Compare
- Added mappings to HGNC symbols - Added mappings to HGNC IDs - data/hgnc: Added this directory and populated with mapping file(s) More minor updates - Minor code formatting - Some code documentation - Some cases of skos:exactMatch -> oboInOwl:hasExactSynonym data/ - Added HGNC folder and file as mentioned earlier. - Added TSV versions of some .txt files Created new omim.ttl
joeflack4
force-pushed
the
hgnc-mappings-and-skosExactMatch
branch
5 times, most recently
from
b4c16a3
to
a4c70c1
Compare
- New omim.ttl - Also now generating omim.sssom.tsv for release makefile - Added SSSOM command Requirements - Added sssom to Pipfile data/ - Updated HGNC mapping file to a better one. - Removed some TSV variations on canonical OMIM files Ingest updates - Now creates TSVs in data/ cache - Now downloads genemap2.txt - oboInOwl:hasDbXref --> skosExactMatch - Did for UMLS - Did for Orphanet - Did in one other location - Updated curie_map .gitignore - Added some new files
joeflack4
force-pushed
the
hgnc-mappings-and-skosExactMatch
branch
from
a4c70c1
to
b23ae87
Compare
|
I think it would make sense if these kinds of PR would get a quick review in general! Either by me, or Harshad, or Chris. I think PR reviews are essential for gradual improvement and learning (both on the side of the reviewer, who learns new cool programing tricks from the coder, and from the coder).. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HGNC-related updates
More minor updates
skos:exactMatch->oboInOwl:hasExactSynonym