Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user guides: adapt and update .po and .md files of verification-allos-advanced.md #1639

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

erciccione
Copy link
Contributor

#1626 has been merged, so now as for the new structure introduced with #1270, we don't need to update each file manually. po4a will do the annoying work for us.

This PR is the result of running for each language:

export langw="<LANG>"

po4a-updatepo -f text -m _i18n/en/resources/user-guides/verification-allos-advanced.md -p _i18n/$langw/resources/user-guides/weblate/verification-allos-advanced.po && po4a-translate -L UTF-8 -f text -m _i18n/en/resources/user-guides/verification-allos-advanced.md -p _i18n/$langw/resources/user-guides/weblate/verification-allos-advanced.po -l _i18n/$langw/resources/user-guides/verification-allos-advanced.md --keep 0

po4a-updatepo is used to update the .po files, which will be used by translators. po4a-translate converts the .po files back to markdown.

This workflow will be more automatized in the future by using po4a(1) or a script.

@erciccione
Copy link
Contributor Author

erciccione commented May 22, 2021

Looking up the issue with netlify. Fixed with #1640.

4b 9f 31 68 6e ca ad 97 cd b1 75 e6 57 4b f3 07 f8 d1 c4 10 42 78 25 f4 30 4c 21 da 8a ac 18 64
CertUtil: -hashfile command completed successfully.
```
``` SHA256 hash of file monero-gui-win-x64-v0.12.0.0.zip: 4b 9f 31 68 6e ca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these line breaks show up on the website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't. The structure of the guide should remain the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@erciccione erciccione May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it now. I haven't noticed it using my local markdown previewer. Looking into fixing it. The structure got messed up by the first commit wrapping the .md file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, for some reason there is no way to avoid wrapping usnig the the po4a-* tools. I had to create a configuration file and a workflow for po4a to fix this problem. I have the config file saved locally, i'll tweak it to work for all docs and then i'll PR.

There should be no more problems caused by unexpected wrapping in these files.

```
wget -O monero-linux-x64-v0.15.0.1.tar.bz2 https://downloads.getmonero.org/cli/linux64
```
``` wget -O monero-linux-x64-v0.15.0.1.tar.bz2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also don't want a line break e.g. here.

@netlify
Copy link

netlify bot commented May 23, 2021

✔️ Deploy Preview for barolo-time-757cf9 ready!

🔨 Explore the source changes: 76d9631

🔍 Inspect the deploy log: https://app.netlify.com/sites/barolo-time-757cf9/deploys/60daf2e8004b84000778dec8

😎 Browse the preview: https://deploy-preview-1639--barolo-time-757cf9.netlify.app

@erciccione
Copy link
Contributor Author

Reminder: this is ready for a final review (see #1639 (comment))

@selsta
Copy link
Contributor

selsta commented Jun 28, 2021

I don't know how to review this. It still looks wrong in the netlify preview.

@erciccione
Copy link
Contributor Author

@selsta i was wrong. I haven't pushed the fixes yet. Converting this to draft for now.

@erciccione erciccione marked this pull request as draft June 29, 2021 09:50
@erciccione
Copy link
Contributor Author

Turns out i did push the fixes, but that reverted a change to a string that i had moved because the structure wasn't compatible with po4a, but was showing ok on the markdown preview of my IDE. Reverted back and updated the .po and .pot files. Everything should be good now.

@erciccione erciccione marked this pull request as ready for review June 29, 2021 10:23
Copy link
Contributor

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a couple files and they seem ok.

@luigi1111 luigi1111 merged commit 4382e7a into monero-project:master Jul 6, 2021
@erciccione erciccione deleted the poup branch July 7, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants