feat: show survey VSCODE-562 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmarcon Could you have a look at the message and let me know if it looks okay to you? (see screenshot) The new wording has been proposed by Gaurab, but he hasn't seen the final version before going OOO. |
|
@paula-stacho LGTM! |
paula-stacho
force-pushed
the
VSCODE-562
branch
from
76cc2b8 to
8d24694
Compare
paula-stacho
force-pushed
the
VSCODE-562
branch
from
8d24694 to
2db67af
Compare
Anemy
approved these changes
Aug 20, 2024
src/mdbExtensionController.ts
Outdated
| const action = 'Share your thoughts'; | ||
| const text = 'How can we make the MongoDB extension better for you?'; | ||
| const link = 'https://forms.gle/9viN9wcbsC3zvHyg7'; | ||
| const result = await vscode.window.showInformationMessage( |
There was a problem hiding this comment.
Is this something we also want to track in telemetry? Like how many folks are shown the survey and dismiss or click? cc @mmarcon
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
| @@ -150,6 +150,7 @@ export default class MDBExtensionController implements vscode.Disposable { | |||
|
|
|||
| this.registerCommands(); | |||
| this.showOverviewPageIfRecentlyInstalled(); | |||
| void this.showSurveyForEstablishedUsers(); | |||
There was a problem hiding this comment.
Do we show this survey to every user of the extension? I remember @GaurabAryal was thinking of limiting the number of users who participate, e.g. 1 out of 10 users will see it.
There was a problem hiding this comment.
Oh really? He didn't mention anything like that, but we only spoke briefly before he went OOO.
alenakhineika
added a commit
that referenced
this pull request
Aug 26, 2024
* chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784) * feat: show survey VSCODE-562 (#780) --------- Co-authored-by: Rhys <Anemy@users.noreply.github.com> Co-authored-by: Rhys Howell <rhys.howell@mongodb.com> * fix: add telemetry events for survey VSCODE-595 (#787) * fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789) --------- Co-authored-by: Rhys <Anemy@users.noreply.github.com> Co-authored-by: Paula Stachova <paula.stachova@tutanota.com> Co-authored-by: Rhys Howell <rhys.howell@mongodb.com>
alenakhineika
added a commit
that referenced
this pull request
Sep 2, 2024
* chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784) * feat: show survey VSCODE-562 (#780) --------- Co-authored-by: Rhys <Anemy@users.noreply.github.com> Co-authored-by: Rhys Howell <rhys.howell@mongodb.com> * fix: add telemetry events for survey VSCODE-595 (#787) * fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789) * fix(deps): bump shell and data-service deps VSCODE-564 (#794) * fix: clean-up webpack config VSCODE-597 (#795) * Update changelog (#796) Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com> * Update changelog (#797) Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com> * fix: cannot find module electron VSCODE-598 (#799) * Update changelog (#801) Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com> * Update changelog (#802) Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com> --------- Co-authored-by: Rhys <Anemy@users.noreply.github.com> Co-authored-by: Paula Stachova <paula.stachova@tutanota.com> Co-authored-by: Rhys Howell <rhys.howell@mongodb.com> Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>
nirinchev
added a commit
that referenced
this pull request
Sep 10, 2024
* main: chore(ci): Update deprecated github actions (#813) Update changelog (#802) Update changelog (#801) fix: cannot find module electron VSCODE-598 (#799) Update changelog (#797) Update changelog (#796) fix: clean-up webpack config VSCODE-597 (#795) fix(deps): bump shell and data-service deps VSCODE-564 (#794) fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789) fix: add telemetry events for survey VSCODE-595 (#787) feat: show survey VSCODE-562 (#780) chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/VSCODE-562
We had to adjust the wording, because the information message doesn't support formatting - so we cannot have a title and subtitle as planned. Alternative would be to show a popup, which is much more intrusive.
The prompt is shown at activation, for users who
a) haven't been shown the survey before
b) already have some connections (indicating this is not their first plugin activation)
Note: I am saving the shown survey not as a boolean, but by "id", as I imagine we might have different surveys later.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes