Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): use ts source map in tests, improve test cleanup error handling VSCODE-593 #784

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Aug 20, 2024

VSCODE-593

Updates our VSCode mocha integration tests to show the typescript file location when there's an error (use the source map).

Also a bit of a drive-by I updated how we run the tests to remove a generic error we'd show and also to have better cleanup. Previously if someone was running the tests and ctrl + c'd then we wouldn't run the cleanup and sometimes we'd have a zombie mongod running.

before after
Screenshot 2024-08-20 at 2 18 04 PM Screenshot 2024-08-20 at 2 06 54 PM

Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@Anemy Anemy merged commit a29b4e2 into main Aug 21, 2024
5 checks passed
@Anemy Anemy deleted the VSCODE-593-fix-test-output-sourcemap branch August 21, 2024 11:30
alenakhineika added a commit that referenced this pull request Aug 26, 2024
* chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784)

* feat: show survey VSCODE-562 (#780)


---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Rhys Howell <rhys.howell@mongodb.com>

* fix: add telemetry events for survey VSCODE-595 (#787)

* fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789)

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Paula Stachova <paula.stachova@tutanota.com>
Co-authored-by: Rhys Howell <rhys.howell@mongodb.com>
alenakhineika added a commit that referenced this pull request Sep 2, 2024
* chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784)

* feat: show survey VSCODE-562 (#780)


---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Rhys Howell <rhys.howell@mongodb.com>

* fix: add telemetry events for survey VSCODE-595 (#787)

* fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789)

* fix(deps): bump shell and data-service deps VSCODE-564 (#794)

* fix: clean-up webpack config VSCODE-597 (#795)

* Update changelog (#796)

Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>

* Update changelog (#797)

Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com>

* fix: cannot find module electron VSCODE-598 (#799)

* Update changelog (#801)

Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>

* Update changelog (#802)

Co-authored-by: alenakhineika <16307679+alenakhineika@users.noreply.github.com>

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Paula Stachova <paula.stachova@tutanota.com>
Co-authored-by: Rhys Howell <rhys.howell@mongodb.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mcasimir <334881+mcasimir@users.noreply.github.com>
nirinchev added a commit that referenced this pull request Sep 10, 2024
* main:
  chore(ci): Update deprecated github actions (#813)
  Update changelog (#802)
  Update changelog (#801)
  fix: cannot find module electron VSCODE-598 (#799)
  Update changelog (#797)
  Update changelog (#796)
  fix: clean-up webpack config VSCODE-597 (#795)
  fix(deps): bump shell and data-service deps VSCODE-564 (#794)
  fix(editors): don't show connect code lens on regular js files VSCODE-538 (#789)
  fix: add telemetry events for survey VSCODE-595 (#787)
  feat: show survey VSCODE-562 (#780)
  chore(testing): use source map support, improve test cleanup error handling VSCODE-593 (#784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants