Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template_types: task 4: document template types and regression tests pack #237

Closed
chfw opened this issue Feb 26, 2019 · 0 comments · Fixed by #240
Closed

template_types: task 4: document template types and regression tests pack #237

chfw opened this issue Feb 26, 2019 · 0 comments · Fixed by #240
Assignees
@chfw

Comments

@chfw
Copy link
Member

chfw commented Feb 26, 2019 •
edited
Loading

This issue notes that level 18 should written to "bank" the work (#233, #235)

#202
@chfw chfw self-assigned this Feb 26, 2019
chfw added a commit that referenced this issue Feb 27, 2019
@chfw
📚 provide documentation on template_types under configuration. fix #237
c7706d4
chfw added a commit that referenced this issue Feb 27, 2019
@chfw
📚 provide documentation on template_types under configuration. fix #237
4091cf8
@chfw chfw mentioned this issue Feb 27, 2019
Merged
@chfw chfw closed this as completed in #240 Feb 27, 2019
chfw added a commit that referenced this issue Feb 27, 2019
@chfw
📚 provide documentation on template_types under configuration. fix #237…
667317f 
… (#240)
chfw added a commit that referenced this issue Feb 28, 2019
@chfw
release 0.4.1 (#241)
217608f 
* Lower dependencies (#232)

* ✨ port minimum requirement test via pypi-mobans from pyexcel. #187

* 🐛 fix travis ci file

* 🐛 update unit tests

* :wheel_chair: lower the dependencies

* 💄 pump up the version number

* Minor code refactoring (#236)

* 🔨 code refactoring

* 💄 reformat code

* 📚 fix doc build

* 🐛 fix docs build

* Initial prototype for 202 template types (#239)

* 🔨 code refactoring

* 💄 reformat code

* 🔥 remove MobanEngine's reference to the engine class

* 🔨 refactoring the code and un-bury engine instance

* ✨ initial prototype, not tested. #235

* 📚 fix doc build

* 🐛 fix docs build

* 🔨 refactoring. user define template takes precedence

* 🔬 test user define engine

* ✨ associate user defined file extensions with user defined template engine name, i.e. custom_jinja for jinja2, custom_handlebars for handlebars, #235

* ✨ take template types from moban file. related to #233

* 🔨 address the feedback

* 🐛 fix typos and add line feed

* 💄 beautify the code

* 📚 provide documentation on template_types under configuration. fix #237 (#240)

* 📚 update change log.#232, #235

* 💄 address review feedback
ayan-b pushed a commit to ayan-b/moban that referenced this issue Apr 21, 2019
@chfw @ayan-b
📚 provide documentation on template_types under configuration. fix mo…
6bb2196 
…remoban#237 (moremoban#240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfw chfw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

📚 provide documentation on template_types under configuration. … moremoban/moban
1 participant
@chfw