Minor code refactoring #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #236 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 57 57
Lines 2352 2352
=======================================
Hits 2336 2336
Misses 16 16
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #236 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 57 57
Lines 2352 2352
=======================================
Hits 2336 2336
Misses 16 16
Continue to review full report at Codecov.
|
ayan-b
approved these changes
Feb 24, 2019
chfw
added a commit
that referenced
this pull request
Feb 28, 2019
* Lower dependencies (#232) * ✨ port minimum requirement test via pypi-mobans from pyexcel. #187 * 🐛 fix travis ci file * 🐛 update unit tests * :wheel_chair: lower the dependencies * 💄 pump up the version number * Minor code refactoring (#236) * 🔨 code refactoring * 💄 reformat code * 📚 fix doc build * 🐛 fix docs build * Initial prototype for 202 template types (#239) * 🔨 code refactoring * 💄 reformat code * 🔥 remove MobanEngine's reference to the engine class * 🔨 refactoring the code and un-bury engine instance * ✨ initial prototype, not tested. #235 * 📚 fix doc build * 🐛 fix docs build * 🔨 refactoring. user define template takes precedence * 🔬 test user define engine * ✨ associate user defined file extensions with user defined template engine name, i.e. custom_jinja for jinja2, custom_handlebars for handlebars, #235 * ✨ take template types from moban file. related to #233 * 🔨 address the feedback * 🐛 fix typos and add line feed * 💄 beautify the code * 📚 provide documentation on template_types under configuration. fix #237 (#240) * 📚 update change log.#232, #235 * 💄 address review feedback
ayan-b
pushed a commit
to ayan-b/moban
that referenced
this pull request
Apr 21, 2019
* 🔨 code refactoring * 💄 reformat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MobanEngine than TemplateEngine.