Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate dbfs: prefix from error message #712

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Remove duplicate dbfs: prefix from error message #712

merged 1 commit into from
Jun 25, 2024

Conversation

vanshcsingh
Copy link
Contributor

@vanshcsingh vanshcsingh commented Jun 25, 2024 •
edited
Loading

Description of changes:

Remove the duplicate dbfs: prefix from the FileNotFoundError message thrown when a unity catalog volume is not found upon invocation of download_from_databricks_unity_catalog

Issue #, if available:

N/A

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

snarayan21
snarayan21 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber calm. ty!

@snarayan21 snarayan21 enabled auto-merge (squash) June 25, 2024 02:22
@snarayan21 snarayan21 merged commit 517dc6d into main Jun 25, 2024
8 checks passed
@snarayan21 snarayan21 deleted the vansh-streaming-1 branch June 25, 2024 02:26
orionw pushed a commit to orionw/streaming that referenced this pull request Jul 10, 2024
@vanshcsingh @orionw
Remove duplicate dbfs: prefix from error message (mosaicml#712)
522128e
XiaohanZhangCMU added a commit that referenced this pull request Jul 11, 2024
@orionw @snarayan21
@vanshcsingh @bigning @XiaohanZhangCMU @dependabot
Add HF File System Support to Streaming (#711)
55e83ec 
* init commit for hf

* fix reqs

* fix test

* change error name; throw error; fix reqs

* Update docs/source/how_to_guides/configure_cloud_storage_credentials.md

Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>

* fix test credential failure

* cleanup

* Remove duplicate `dbfs:` prefix from error message (#712)

* fix typo in tests

* docs

* Try to figure out what is wrong with lint; test

* fix os join

* try to fix precommit

* a (#713)

* Upgrade ci_testing, remove codeql (#714)

* linting_codeql

* yo

* yo

* Wrap with nparray (#719)

* Bump pydantic from 2.7.4 to 2.8.2 (#718)

Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.7.4 to 2.8.2.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.4...v2.8.2)

---
updated-dependencies:
- dependency-name: pydantic
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>

* Bump databricks-sdk from 0.28.0 to 0.29.0 (#715)

Bumps [databricks-sdk](https://github.com/databricks/databricks-sdk-py) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/databricks/databricks-sdk-py/releases)
- [Changelog](https://github.com/databricks/databricks-sdk-py/blob/main/CHANGELOG.md)
- [Commits](databricks/databricks-sdk-py@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: databricks-sdk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>

* update docstring

* add isort

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>
Co-authored-by: Vansh Singh <vansh.singh@databricks.com>
Co-authored-by: bigning <bigning1118@gmail.com>
Co-authored-by: Saaketh Narayan <saaketh.narayan@databricks.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@karan6181 karan6181 Awaiting requested review from karan6181

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanshcsingh @snarayan21