Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ci_testing, remove codeql #714

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Upgrade ci_testing, remove codeql #714

merged 4 commits into from
Jun 28, 2024
+1 −59

Conversation

snarayan21
Copy link
Collaborator

Description of changes:

Upgrading ci_testing version to latest 0.0.9. Also removing codeql workflow, similar to mosaicml/composer#3429

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@snarayan21 snarayan21 merged commit 7089eef into main Jun 28, 2024
7 checks passed
@snarayan21 snarayan21 deleted the saaketh/ci_testing_9 branch June 28, 2024 23:27
orionw pushed a commit to orionw/streaming that referenced this pull request Jul 10, 2024
@snarayan21 @orionw
Upgrade ci_testing, remove codeql (mosaicml#714)
a1ee866 
* linting_codeql

* yo

* yo
XiaohanZhangCMU added a commit that referenced this pull request Jul 11, 2024
@orionw @snarayan21
@vanshcsingh @bigning @XiaohanZhangCMU @dependabot
Add HF File System Support to Streaming (#711)
55e83ec 
* init commit for hf

* fix reqs

* fix test

* change error name; throw error; fix reqs

* Update docs/source/how_to_guides/configure_cloud_storage_credentials.md

Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>

* fix test credential failure

* cleanup

* Remove duplicate `dbfs:` prefix from error message (#712)

* fix typo in tests

* docs

* Try to figure out what is wrong with lint; test

* fix os join

* try to fix precommit

* a (#713)

* Upgrade ci_testing, remove codeql (#714)

* linting_codeql

* yo

* yo

* Wrap with nparray (#719)

* Bump pydantic from 2.7.4 to 2.8.2 (#718)

Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.7.4 to 2.8.2.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.4...v2.8.2)

---
updated-dependencies:
- dependency-name: pydantic
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>

* Bump databricks-sdk from 0.28.0 to 0.29.0 (#715)

Bumps [databricks-sdk](https://github.com/databricks/databricks-sdk-py) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/databricks/databricks-sdk-py/releases)
- [Changelog](https://github.com/databricks/databricks-sdk-py/blob/main/CHANGELOG.md)
- [Commits](databricks/databricks-sdk-py@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: databricks-sdk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>

* update docstring

* add isort

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>
Co-authored-by: Vansh Singh <vansh.singh@databricks.com>
Co-authored-by: bigning <bigning1118@gmail.com>
Co-authored-by: Saaketh Narayan <saaketh.narayan@databricks.com>
Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg dakinggg approved these changes

@b-chu b-chu Awaiting requested review from b-chu

@bigning bigning Awaiting requested review from bigning

@eracah eracah Awaiting requested review from eracah

@karan6181 karan6181 Awaiting requested review from karan6181

@j316chuck j316chuck Awaiting requested review from j316chuck

@XiaohanZhangCMU XiaohanZhangCMU Awaiting requested review from XiaohanZhangCMU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snarayan21 @mvpatel2000 @dakinggg