Update ArcBallCamera.h #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the frustum clip distance. The current 'far' clip is too small, thus some large objects can be cut off.
|
Hmm, this could cause depth precision issues on certain browsers / platforms which use a 16-bit depth buffer by default. I'm not sure what's the situation right now but not so long ago Firefox suffered quite a lot from this (see #34, https://bugzilla.mozilla.org/show_bug.cgi?id=1202387). Maybe a better option would be to make this configurable from outside? So you extend it where needed and leave in safe bounds where the default is enough. |
Add near/far parameters for the frustum.
|
Sure. I changed that. Now the near/far parameters are optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the frustum clip distance. The current 'far' clip is too small, thus some large objects can be cut off.