Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Spinner constraint fixes for languages with longer strings #1027

Merged
merged 3 commits into from
May 29, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 29, 2019

Fixes #1010
Connected to #1009

Testing and Review Notes

Might be worth a UX review, I increased the height of the spinner alert by a few pixels to accommodate the two line message.

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 29, 2019 17:02
@sashei sashei requested a review from a team May 29, 2019 17:02
@sashei sashei changed the title adjust constraints for multi-line sync messages constraint fixes for languages with longer strings May 29, 2019
@devinreams
Copy link
Contributor

@changecourse here's a quick screenshot of the adjusted spinner.

in French:

image

in German:

image

in English:

image

So the only change I thought may be worthwhile:

The constraint at the bottom of the spinner feels a little "tight" (not enough breathing room)

...anything else you think worth considering while we're in there?

@devinreams
Copy link
Contributor

Oh I also did some autofill fixes over at #1030 when I was testing against German 😊

@devinreams devinreams changed the title constraint fixes for languages with longer strings Spinner constraint fixes for languages with longer strings May 29, 2019
@devinreams devinreams merged commit f74d69a into master May 29, 2019
@devinreams devinreams deleted the 1010-syncing-spinner-cut-off branch May 29, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“Syncing your logins…” spinner is cut out in French
2 participants