Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Wrap long strings on autofill, item detail, and item list so all words fit #1030

Merged
merged 6 commits into from
May 29, 2019

Conversation

devinreams
Copy link
Contributor

@devinreams devinreams commented May 29, 2019

Fixes #1029

Screenshots or Videos

Autofill instructions

Screen Shot 2019-05-29 at 12 08 14 PM

Learn more on item detail

Screen Shot 2019-05-29 at 12 23 38 PM

(was the easiest way to keep that arrow around at this point)

Learn more on item list

Screen Shot 2019-05-29 at 12 18 32 PM

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • consider running this branch in the simulator and check for warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@devinreams devinreams requested a review from a team May 29, 2019 18:24
@devinreams devinreams requested a review from a team as a code owner May 29, 2019 18:24
@devinreams devinreams changed the title 1029 wrap 1029: Wrap so long strings on autofill, item detail, and item list will fit May 29, 2019
@devinreams devinreams changed the title 1029: Wrap so long strings on autofill, item detail, and item list will fit Wrap so long strings on autofill, item detail, and item list will fit May 29, 2019
Copy link
Contributor

@sashei sashei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very speedy, nice @devinreams 🐌

@devinreams devinreams changed the title Wrap so long strings on autofill, item detail, and item list will fit Wrap long strings on autofill, item detail, and item list so all words fit May 29, 2019
@sashei
Copy link
Contributor

sashei commented May 29, 2019

@devinreams it might be worth thinking about how much padding to have on the trailing side; I think <~20 or so would be nice but maybe @changecourse has another opinion.

@devinreams
Copy link
Contributor Author

it might be worth thinking about how much padding to have on the trailing side; I think <~20 or so would be nice

Yeah I wanted to achieve that with the "desired width" because adding more constraints ended up having a lot of adverse side effects on other screen sizes and other cascading constraints.

I took another look and did the wrong width so it's a bit more centered/tighter now and looks good and centered on iPad too still:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translated strings don't wrap on autofill instruction or item detail screens
2 participants