Add FXIOS-8703 Share action to library items context menu #19333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
commented
Mar 21, 2024
| actions.append(PhotonRowActions(removeAction)) | ||
|
|
||
| let cell = tableView.cellForRow(at: indexPath) | ||
| actions.append(getShareAction(site: site, sourceView: cell ?? self.view, delegate: historyCoordinatorDelegate)) |
There was a problem hiding this comment.
only changed this line, but moved the code from HistoryPanel+ContextMenuExtensions to here
Client.app: Coverage: 32.47
Generated by 🚫 Danger Swift against d2dbc46 |
thatswinnie
approved these changes
Mar 22, 2024
|
@mergify backport release/v125 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 866dc8b)
rojinpra7
pushed a commit
to rojinpra7/firefox-ios
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Add Share Option to Library Menus (Bookmark, History, Reading List).
LibraryPanelCoordinatorDelegateso that Bookmark, Reading List, History delegates can conform to it + reduce code.LibraryNavigationHandlerso that all the panels can create the share extension via theLibraryCoordinator.HistoryPanel+ContextMenuExtensionstoHistoryPaneland use MARK instead of extension as per wiki: https://github.com/mozilla-mobile/firefox-ios/wiki/When-To-Use-Extensions. This also allows us to access the privatetableViewproperty.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)Screenshots