Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-8703 Share action to library items context menu (backport #19333) #19349

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Add Share Option to Library Menus (Bookmark, History, Reading List).

  • Created a shared protocol LibraryPanelCoordinatorDelegate so that Bookmark, Reading List, History delegates can conform to it + reduce code.
  • Passed in LibraryNavigationHandler so that all the panels can create the share extension via the LibraryCoordinator.
  • Moved HistoryPanel+ContextMenuExtensions to HistoryPanel and use MARK instead of extension as per wiki: https://github.com/mozilla-mobile/firefox-ios/wiki/When-To-Use-Extensions. This also allows us to access the private tableView property.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

Screenshots

Bookmarks History Reading List
Simulator Screenshot - iPhone 15 Pro - 2024-03-21 at 10 16 51 Simulator Screenshot - iPhone 15 Pro - 2024-03-21 at 10 16 59 Simulator Screenshot - iPhone 15 Pro - 2024-03-21 at 10 17 07

@mergify mergify bot requested a review from a team as a code owner March 22, 2024 12:56
@mergify mergify bot requested review from adudenamedruby and removed request for a team March 22, 2024 12:56
@cyndichin cyndichin requested review from cyndichin and removed request for adudenamedruby March 22, 2024 12:58
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.78%
📖 Edited 13 files
📖 Created 2 files

Client.app: Coverage: 32.5

File Coverage
HistoryCoordinator.swift 89.47%
BookmarksCoordinator.swift 78.26%
ReaderPanel.swift 44.93% ⚠️
HistoryPanel.swift 37.69% ⚠️
ReadingListCoordinator.swift 100.0%
LibraryCoordinator.swift 91.41%
BookmarksPanel.swift 39.64% ⚠️
LibraryPanelContextMenu.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against d20c439

@cyndichin cyndichin merged commit 9070575 into release/v125 Mar 22, 2024
12 checks passed
@cyndichin cyndichin deleted the mergify/bp/release/v125/pr-19333 branch March 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants