Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: proper cleanup on shutdown #9559

Merged
merged 3 commits into from
Jun 7, 2024

lint

91956cf
Select commit
Loading
Failed to load commit list.
Merged

Nit: proper cleanup on shutdown #9559

lint
91956cf
Select commit
Loading
Failed to load commit list.
firefoxci-taskcluster / source-test-clang-tidy-windows succeeded Jun 7, 2024 in 17m 4s

FirefoxCI (pull_request)

Clang-tidy (Treeherder push)

Details

View task in Taskcluster
View logs in Taskcluster


[task 2024-06-07T18:04:32.024Z] 6660 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 6660 warnings (6660 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpfijo4hcx.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\collator.cpp
[task 2024-06-07T18:04:32.024Z] 4410 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 4410 warnings (4410 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpx_3bm9zt.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\addons\conditionwatchers\addonconditionwatchertriggertimesecs.cpp
[task 2024-06-07T18:04:32.024Z] 5497 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 5497 warnings (5497 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmp0gryr6qe.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\inspector\inspectoritempicker.cpp
[task 2024-06-07T18:04:32.024Z] 3312 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 3312 warnings (3312 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpfllkxuvt.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\addons\conditionwatchers\addonconditionwatcherjavascript.cpp
[task 2024-06-07T18:04:32.024Z] 5119 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 5119 warnings (5119 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmplkrreq7d.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\hawkauth.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\hawkauth.cpp:55:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.024Z]   return QString(digest.toBase64());
[task 2024-06-07T18:04:32.024Z]          ^
[task 2024-06-07T18:04:32.024Z] 4221 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 4220 warnings (4220 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpeeq9okph.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\feature\featuremodel.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\feature\featuremodel.cpp:159:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.024Z]     return QVariant();
[task 2024-06-07T18:04:32.024Z]            ^~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]            {}
[task 2024-06-07T18:04:32.024Z] 6912 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 6911 warnings (6911 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmp98af_8vz.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\addons\conditionwatchers\addonconditionwatchergroup.cpp
[task 2024-06-07T18:04:32.024Z] 3380 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 3380 warnings (3380 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpljq7h2qa.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\tasks\addonindex\taskaddonindex.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\tasks\addonindex\taskaddonindex.cpp:29:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]     NetworkRequest* request = new NetworkRequest(this, 200);
[task 2024-06-07T18:04:32.024Z]     ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]     auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\tasks\addonindex\taskaddonindex.cpp:54:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]     NetworkRequest* request = new NetworkRequest(this, 200);
[task 2024-06-07T18:04:32.024Z]     ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]     auto
[task 2024-06-07T18:04:32.024Z] 5053 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 5051 warnings (5051 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmp476xmre5.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\addons\conditionwatchers\addonconditionwatchertranslationthreshold.cpp
[task 2024-06-07T18:04:32.024Z] 4957 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 4957 warnings (4957 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmp6fdscwdr.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:37:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(parent, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:93:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(task);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:176:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:303:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:381:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:442:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:657:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\authenticationinapp\authenticationinappsession.cpp:790:9: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]         NetworkRequest* request = new NetworkRequest(m_task, 200);
[task 2024-06-07T18:04:32.024Z]         ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]         auto
[task 2024-06-07T18:04:32.024Z] 8926 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 8918 warnings (8918 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpr5xthe88.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\addons\addon.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\addons\addon.cpp:423:33: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T18:04:32.024Z]              const QString& id, const QString& name, const QString& type)
[task 2024-06-07T18:04:32.024Z]                                 ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]                                 QString 
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\addons\addon.cpp:423:54: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T18:04:32.024Z]              const QString& id, const QString& name, const QString& type)
[task 2024-06-07T18:04:32.024Z]                                                      ^~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]                                                      QString 
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\addons\addon.cpp:491:19: warning: Value stored to 'settingsHolder' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-06-07T18:04:32.024Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T18:04:32.024Z]                   ^~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\addons\addon.cpp:491:19: note: Value stored to 'settingsHolder' during its initialization is never read
[task 2024-06-07T18:04:32.024Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T18:04:32.024Z]                   ^~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\addons\addon.cpp:687:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   QTranslator* translator = new QTranslator(this);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] 8083 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 8079 warnings (8079 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmprkif42zr.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\qmlpath.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\qmlpath.cpp:217:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   QQuickItem* contentItem = item->property("contentItem").value<QQuickItem*>();
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] 9367 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 9366 warnings (9366 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmp9os_u_gu.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\sentry\sentryadapter.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\sentry\sentryadapter.cpp:81:65: warning: use nullptr [modernize-use-nullptr]
[task 2024-06-07T18:04:32.024Z]   sentry_options_set_on_crash(options, &SentryAdapter::onCrash, NULL);
[task 2024-06-07T18:04:32.024Z]                                                                 ^~~~
[task 2024-06-07T18:04:32.024Z]                                                                 nullptr
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\sentry\sentryadapter.cpp:113:38: warning: use nullptr [modernize-use-nullptr]
[task 2024-06-07T18:04:32.024Z]     sentry_value_set_stacktrace(exc, NULL, 0);
[task 2024-06-07T18:04:32.024Z]                                      ^~~~
[task 2024-06-07T18:04:32.024Z]                                      nullptr
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\sentry\sentryadapter.cpp:135:64: warning: parameter 'uctx' is unused [misc-unused-parameters]
[task 2024-06-07T18:04:32.024Z] sentry_value_t SentryAdapter::onCrash(const sentry_ucontext_t* uctx,
[task 2024-06-07T18:04:32.024Z]                                                                ^~~~
[task 2024-06-07T18:04:32.024Z]                                                                 /*uctx*/
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\sentry\sentryadapter.cpp:136:67: warning: parameter 'closure' is unused [misc-unused-parameters]
[task 2024-06-07T18:04:32.024Z]                                       sentry_value_t event, void* closure) {
[task 2024-06-07T18:04:32.024Z]                                                                   ^~~~~~~
[task 2024-06-07T18:04:32.024Z]                                                                    /*closure*/
[task 2024-06-07T18:04:32.024Z] 16913 warnings generated.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Suppressed 16909 warnings (16909 in non-user code).
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.024Z] 
[task 2024-06-07T18:04:32.024Z] D:/task_171778292080830/fetches/Library/bin/clang-tidy.exe -export-fixes C:\Users\task_171778292080830\AppData\Local\Temp\tmpfpqur99a\tmpio60xm4z.yaml -p=D:/task_171778292080830/cmake_build D:\task_171778292080830\build\src\src\localizer.cpp
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\localizer.cpp:56:3: warning: use range-based for loop instead [modernize-loop-convert]
[task 2024-06-07T18:04:32.024Z]   for (int i = 0; i < words.size(); i++) {
[task 2024-06-07T18:04:32.024Z]   ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]       (auto & i : words)
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\localizer.cpp:367:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T18:04:32.024Z]   QTranslator* translator = new QTranslator(this);
[task 2024-06-07T18:04:32.024Z]   ^~~~~~~~~~~
[task 2024-06-07T18:04:32.024Z]   auto
[task 2024-06-07T18:04:32.024Z] D:\task_171778292080830\build\src\src\localizer.cpp:469:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]     return QVariant();
[task 2024-06-07T18:04:32.025Z]            ^~~~~~~~~~
[task 2024-06-07T18:04:32.025Z]            {}
[task 2024-06-07T18:04:32.025Z] D:\task_171778292080830\build\src\src\localizer.cpp:476:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]       return QVariant(localizedLanguageName(language.m_code));
[task 2024-06-07T18:04:32.025Z]              ^
[task 2024-06-07T18:04:32.025Z] D:\task_171778292080830\build\src\src\localizer.cpp:479:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]       return QVariant(language.m_nativeLanguageName);
[task 2024-06-07T18:04:32.025Z]              ^
[task 2024-06-07T18:04:32.025Z] D:\task_171778292080830\build\src\src\localizer.cpp:482:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]       return QVariant(language.m_code);
[task 2024-06-07T18:04:32.025Z]              ^
[task 2024-06-07T18:04:32.025Z] D:\task_171778292080830\build\src\src\localizer.cpp:485:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]       return QVariant(language.m_rtl);
[task 2024-06-07T18:04:32.025Z]              ^~~~~~~~~              ~
[task 2024-06-07T18:04:32.025Z]              {                      }
[task 2024-06-07T18:04:32.025Z] D:\task_171778292080830\build\src\src\localizer.cpp:488:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
[task 2024-06-07T18:04:32.025Z]       return QVariant();
[task 2024-06-07T18:04:32.025Z]              ^~~~~~~~~~
[task 2024-06-07T18:04:32.025Z]              {}
[task 2024-06-07T18:04:32.025Z] 7455 warnings generated.
[task 2024-06-07T18:04:32.025Z] 
[task 2024-06-07T18:04:32.025Z] Suppressed 7447 warnings (7447 in non-user code).
[task 2024-06-07T18:04:32.025Z] 
[task 2024-06-07T18:04:32.025Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T18:04:32.025Z] 
[task 2024-06-07T18:04:32.025Z] 
[task 2024-06-07T18:04:32.025Z] Writing fixes to D:/task_171778292080830/cmake_build/clang-tidy/shared-sources-report.yaml ...
[task 2024-06-07T18:04:32.025Z] 
[task 2024-06-07T18:04:32.035Z] 
[task 2024-06-07T18:04:32.035Z] 
[task 2024-06-07T18:04:32.036Z]     Directory: D:\task_171778292080830
[task 2024-06-07T18:04:32.036Z] 
[task 2024-06-07T18:04:32.036Z] 
[task 2024-06-07T18:04:32.036Z] Mode                 LastWriteTime         Length Name                                                                                      
[task 2024-06-07T18:04:32.037Z] ----                 -------------         ------ ----                                                                                      
[task 2024-06-07T18:04:32.038Z] d-----          6/7/2024   6:04 PM                artifacts                                                                                 
[task 2024-06-07T18:04:32.042Z] 
[task 2024-06-07T18:04:32.042Z] 
[fetches 2024-06-07T18:04:32.063Z] removing D:\task_171778292080830\fetches
[fetches 2024-06-07T18:04:46.381Z] finished
[taskcluster 2024-06-07T18:04:46.409Z]    Exit Code: 0
[taskcluster 2024-06-07T18:04:46.409Z]    User Time: 0s
[taskcluster 2024-06-07T18:04:46.409Z]  Kernel Time: 31.25ms
[taskcluster 2024-06-07T18:04:46.409Z]    Wall Time: 8m20.2824344s
[taskcluster 2024-06-07T18:04:46.409Z]       Result: SUCCEEDED
[taskcluster 2024-06-07T18:04:46.409Z] === Task Finished ===
[taskcluster 2024-06-07T18:04:46.409Z] Task Duration: 8m20.2835173s
[taskcluster 2024-06-07T18:04:46.752Z] Uploading artifact public/build/mozillavpn-sources-report.yaml from file D:\task_171778292080830\artifacts\mozillavpn-sources-report.yaml with content encoding "gzip", mime type "application/octet-stream" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:47.109Z] Uploading artifact public/build/mz_webextension-report.yaml from file D:\task_171778292080830\artifacts\mz_webextension-report.yaml with content encoding "gzip", mime type "application/octet-stream" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:47.328Z] Uploading artifact public/build/shared-sources-report.yaml from file D:\task_171778292080830\artifacts\shared-sources-report.yaml with content encoding "gzip", mime type "application/octet-stream" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:47.618Z] Uploading artifact public/logs/certified.log from file D:\task_171778292080830\generic-worker\certified.log with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:47.858Z] Uploading artifact public/chain-of-trust.json from file D:\task_171778292080830\generic-worker\chain-of-trust.json with content encoding "gzip", mime type "text/plain; charset=utf-8" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:48.118Z] Uploading artifact public/chain-of-trust.json.sig from file D:\task_171778292080830\generic-worker\chain-of-trust.json.sig with content encoding "gzip", mime type "application/octet-stream" and expiry 2024-07-05T17:47:43.664Z
[taskcluster 2024-06-07T18:04:48.336Z] [mounts] Preserving cache: Moving "D:\\task_171778292080830\\build" to "D:\\caches\\BOchLqbmTMG6pvZtXYAwFw"
[taskcluster 2024-06-07T18:04:48.347Z] [mounts] Denying task_171778292080830 access to 'D:\caches\BOchLqbmTMG6pvZtXYAwFw'
[taskcluster 2024-06-07T18:04:49.054Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2024-07-05T17:47:43.664Z