Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: proper cleanup on shutdown #9559

Merged
merged 3 commits into from
Jun 7, 2024

lint

91956cf
Select commit
Loading
Failed to load commit list.
Merged

Nit: proper cleanup on shutdown #9559

lint
91956cf
Select commit
Loading
Failed to load commit list.
firefoxci-taskcluster / source-test-clang-tidy-android succeeded Jun 7, 2024 in 8m 51s

FirefoxCI (pull_request)

Clang-tidy (Treeherder push)

Details

View task in Taskcluster
View logs in Taskcluster


[task 2024-06-07T17:56:28.612Z] Suppressed 8718 warnings (8718 in non-user code).
[task 2024-06-07T17:56:28.612Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp9aiiu32e.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:26:19: warning: Value stored to 'settingsHolder' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-06-07T17:56:28.612Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T17:56:28.612Z]                   ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:26:19: note: Value stored to 'settingsHolder' during its initialization is never read
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:37:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.612Z]   AddonMessage* message = new AddonMessage(parent, manifestFileName, id, name);
[task 2024-06-07T17:56:28.612Z]   ^~~~~~~~~~~~
[task 2024-06-07T17:56:28.612Z]   auto
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:93:76: warning: parameter 'id' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.612Z] AddonMessage::MessageStatus AddonMessage::loadMessageStatus(const QString& id) {
[task 2024-06-07T17:56:28.612Z]                                                                            ^~
[task 2024-06-07T17:56:28.612Z]                                                                             /*id*/
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:94:19: warning: Value stored to 'settingsHolder' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-06-07T17:56:28.612Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T17:56:28.612Z]                   ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:94:19: note: Value stored to 'settingsHolder' during its initialization is never read
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-06-07T17:56:28.612Z]     }
[task 2024-06-07T17:56:28.612Z]     ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:200:5: note: Calling 'AddonMessage::planDateRetranslation'
[task 2024-06-07T17:56:28.612Z]     planDateRetranslation();
[task 2024-06-07T17:56:28.612Z]     ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:188:7: note: Assuming field 'm_date' is not equal to 0
[task 2024-06-07T17:56:28.612Z]   if (m_date == 0) {
[task 2024-06-07T17:56:28.612Z]       ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:188:3: note: Taking false branch
[task 2024-06-07T17:56:28.612Z]   if (m_date == 0) {
[task 2024-06-07T17:56:28.612Z]   ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:194:3: note: Taking false branch
[task 2024-06-07T17:56:28.612Z]   if (time == -1) {
[task 2024-06-07T17:56:28.612Z]   ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:198:3: note: Calling 'QTimer::singleShot'
[task 2024-06-07T17:56:28.612Z]   QTimer::singleShot((1 + time) * 1000, this, [this]() {
[task 2024-06-07T17:56:28.612Z]   ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-06-07T17:56:28.612Z]         singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-06-07T17:56:28.612Z]         ^
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), (lambda at /builds/worker/checkouts/vcs/src/addons/addonmessage.cpp:198:47)>'
[task 2024-06-07T17:56:28.612Z]                        QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-06-07T17:56:28.612Z]                        ^
[task 2024-06-07T17:56:28.612Z] 11621 warnings generated.
[task 2024-06-07T17:56:28.612Z] Suppressed 11617 warnings (11616 in non-user code, 1 NOLINT).
[task 2024-06-07T17:56:28.612Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpi42g4yk0.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/feature/taskgetfeaturelist.cpp
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/feature/taskgetfeaturelist.cpp:30:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.612Z]   NetworkRequest* request = new NetworkRequest(this, 200);
[task 2024-06-07T17:56:28.612Z]   ^~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.612Z]   auto
[task 2024-06-07T17:56:28.612Z] 10013 warnings generated.
[task 2024-06-07T17:56:28.612Z] Suppressed 10012 warnings (10012 in non-user code).
[task 2024-06-07T17:56:28.612Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpxb3y27vw.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/app.cpp
[task 2024-06-07T17:56:28.612Z] 8836 warnings generated.
[task 2024-06-07T17:56:28.612Z] Suppressed 8836 warnings (8836 in non-user code).
[task 2024-06-07T17:56:28.612Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.612Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmph30tguc5.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/loghandler.cpp
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:230:53: warning: parameter 'proofOfLock' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.612Z]                         const QMutexLocker<QMutex>& proofOfLock) {
[task 2024-06-07T17:56:28.612Z]                                                     ^~~~~~~~~~~
[task 2024-06-07T17:56:28.612Z]                                                      /*proofOfLock*/
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:338:62: warning: parameter 'proofOfLock' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.612Z] void LogHandler::truncateLogFile(const QMutexLocker<QMutex>& proofOfLock,
[task 2024-06-07T17:56:28.612Z]                                                              ^~~~~~~~~~~
[task 2024-06-07T17:56:28.612Z]                                                               /*proofOfLock*/
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:428:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.612Z]   QString* buffer = new QString();
[task 2024-06-07T17:56:28.612Z]   ^~~~~~~
[task 2024-06-07T17:56:28.612Z]   auto
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:429:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.612Z]   QTextStream* out = new QTextStream(buffer);
[task 2024-06-07T17:56:28.612Z]   ^~~~~~~~~~~
[task 2024-06-07T17:56:28.612Z]   auto
[task 2024-06-07T17:56:28.612Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:472:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.612Z]   QString* buffer = new QString();
[task 2024-06-07T17:56:28.612Z]   ^~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:473:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   QTextStream* out = new QTextStream(buffer);
[task 2024-06-07T17:56:28.613Z]   ^~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:493:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   LogSerializeHelper* lsh = new LogSerializeHelper(out, m_logSerializers,
[task 2024-06-07T17:56:28.613Z]   ^~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:547:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   QFile* file = new QFile(logFile);
[task 2024-06-07T17:56:28.613Z]   ^~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/loghandler.cpp:554:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   QTextStream* out = new QTextStream(file);
[task 2024-06-07T17:56:28.613Z]   ^~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] 8311 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 8302 warnings (8302 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpeo1dcikw.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/addons/manager/addonindex.cpp
[task 2024-06-07T17:56:28.613Z] 11134 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 11134 warnings (11134 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmppvrli6f3.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/settingsholder.cpp
[task 2024-06-07T17:56:28.613Z] 10245 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 10245 warnings (10245 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp641eormo.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/addons/manager/addonmanager.cpp
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/manager/addonmanager.cpp:422:19: warning: Value stored to 'settingsHolder' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-06-07T17:56:28.613Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T17:56:28.613Z]                   ^
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/manager/addonmanager.cpp:422:19: note: Value stored to 'settingsHolder' during its initialization is never read
[task 2024-06-07T17:56:28.613Z] 12146 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 12145 warnings (12145 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp4u925f4d.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/adjust/adjusthandler.cpp
[task 2024-06-07T17:56:28.613Z] 10037 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 10037 warnings (10037 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpxstwsg7b.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/addons/conditionwatchers/addonconditionwatchertriggertimesecs.cpp
[task 2024-06-07T17:56:28.613Z] 8808 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 8808 warnings (8808 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp6mstcjpw.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/addons/addon.cpp
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/addon.cpp:423:33: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T17:56:28.613Z]              const QString& id, const QString& name, const QString& type)
[task 2024-06-07T17:56:28.613Z]                                 ^~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]                                 QString 
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/addon.cpp:423:54: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T17:56:28.613Z]              const QString& id, const QString& name, const QString& type)
[task 2024-06-07T17:56:28.613Z]                                                      ^~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]                                                      QString 
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/addon.cpp:491:19: warning: Value stored to 'settingsHolder' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-06-07T17:56:28.613Z]   SettingsHolder* settingsHolder = SettingsHolder::instance();
[task 2024-06-07T17:56:28.613Z]                   ^
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/addon.cpp:491:19: note: Value stored to 'settingsHolder' during its initialization is never read
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/addons/addon.cpp:687:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   QTranslator* translator = new QTranslator(this);
[task 2024-06-07T17:56:28.613Z]   ^~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] 13212 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 13208 warnings (13208 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp7sl1tvii.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/theme.cpp
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/theme.cpp:120:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]   ThemeData* data = new ThemeData();
[task 2024-06-07T17:56:28.613Z]   ^~~~~~~~~
[task 2024-06-07T17:56:28.613Z]   auto
[task 2024-06-07T17:56:28.613Z] 11263 warnings generated.
[task 2024-06-07T17:56:28.613Z] Suppressed 11262 warnings (11262 in non-user code).
[task 2024-06-07T17:56:28.613Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.613Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpd83evtbp.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:197:69: warning: parameter 'args' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.613Z]                      [](InspectorHandler*, const QList<QByteArray>& args) {
[task 2024-06-07T17:56:28.613Z]                                                                     ^~~~
[task 2024-06-07T17:56:28.613Z]                                                                      /*args*/
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:206:69: warning: parameter 'args' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.613Z]                      [](InspectorHandler*, const QList<QByteArray>& args) {
[task 2024-06-07T17:56:28.613Z]                                                                     ^~~~
[task 2024-06-07T17:56:28.613Z]                                                                      /*args*/
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:307:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]           QQmlApplicationEngine* engine = qobject_cast<QQmlApplicationEngine*>(
[task 2024-06-07T17:56:28.613Z]           ^~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]           auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:309:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]           QObject* item = engine->singletonInstance<QObject*>(id);
[task 2024-06-07T17:56:28.613Z]           ^~~~~~~
[task 2024-06-07T17:56:28.613Z]           auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:333:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]           QQmlApplicationEngine* engine = qobject_cast<QQmlApplicationEngine*>(
[task 2024-06-07T17:56:28.613Z]           ^~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]           auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:335:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]           QObject* item = engine->singletonInstance<QObject*>(id);
[task 2024-06-07T17:56:28.613Z]           ^~~~~~~
[task 2024-06-07T17:56:28.613Z]           auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:364:24: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.613Z]                        QQuickWindow* window = qobject_cast<QQuickWindow*>(
[task 2024-06-07T17:56:28.613Z]                        ^~~~~~~~~~~~
[task 2024-06-07T17:56:28.613Z]                        auto
[task 2024-06-07T17:56:28.613Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:768:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.614Z]     InspectorWebSocketServer* inspectWebSocketServer =
[task 2024-06-07T17:56:28.614Z]     ^~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]     auto
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:902:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.614Z]   QQmlApplicationEngine* engine = qobject_cast<QQmlApplicationEngine*>(
[task 2024-06-07T17:56:28.614Z]   ^~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]   auto
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/inspector/inspectorhandler.cpp:910:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.614Z]     QQuickWindow* window = qobject_cast<QQuickWindow*>(root);
[task 2024-06-07T17:56:28.614Z]     ^~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]     auto
[task 2024-06-07T17:56:28.614Z] 16362 warnings generated.
[task 2024-06-07T17:56:28.614Z] Suppressed 16331 warnings (16331 in non-user code).
[task 2024-06-07T17:56:28.614Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.614Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpf9yizxmt.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/sentry/sentryadapter.cpp
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/sentry/sentryadapter.cpp:81:65: warning: use nullptr [modernize-use-nullptr]
[task 2024-06-07T17:56:28.614Z]   sentry_options_set_on_crash(options, &SentryAdapter::onCrash, NULL);
[task 2024-06-07T17:56:28.614Z]                                                                 ^~~~
[task 2024-06-07T17:56:28.614Z]                                                                 nullptr
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/sentry/sentryadapter.cpp:113:38: warning: use nullptr [modernize-use-nullptr]
[task 2024-06-07T17:56:28.614Z]     sentry_value_set_stacktrace(exc, NULL, 0);
[task 2024-06-07T17:56:28.614Z]                                      ^~~~
[task 2024-06-07T17:56:28.614Z]                                      nullptr
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/sentry/sentryadapter.cpp:135:64: warning: parameter 'uctx' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.614Z] sentry_value_t SentryAdapter::onCrash(const sentry_ucontext_t* uctx,
[task 2024-06-07T17:56:28.614Z]                                                                ^~~~
[task 2024-06-07T17:56:28.614Z]                                                                 /*uctx*/
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/sentry/sentryadapter.cpp:136:67: warning: parameter 'closure' is unused [misc-unused-parameters]
[task 2024-06-07T17:56:28.614Z]                                       sentry_value_t event, void* closure) {
[task 2024-06-07T17:56:28.614Z]                                                                   ^~~~~~~
[task 2024-06-07T17:56:28.614Z]                                                                    /*closure*/
[task 2024-06-07T17:56:28.614Z] 18023 warnings generated.
[task 2024-06-07T17:56:28.614Z] Suppressed 18019 warnings (18019 in non-user code).
[task 2024-06-07T17:56:28.614Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.614Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpkrryonl9.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/feature/feature.cpp
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/feature/feature.cpp:66:37: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T17:56:28.614Z] Feature::Feature(const QString& id, const QString& name,
[task 2024-06-07T17:56:28.614Z]                                     ^~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]                                     QString 
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/feature/feature.cpp:69:18: warning: pass by value and use std::move [modernize-pass-by-value]
[task 2024-06-07T17:56:28.614Z]                  const QStringList& featureDependencies,
[task 2024-06-07T17:56:28.614Z]                  ^~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]                  QStringList 
[task 2024-06-07T17:56:28.614Z] 9061 warnings generated.
[task 2024-06-07T17:56:28.614Z] Suppressed 9059 warnings (9059 in non-user code).
[task 2024-06-07T17:56:28.614Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.614Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmpp568j6xr.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/feature/featuremodel.cpp
[task 2024-06-07T17:56:28.614Z] 10655 warnings generated.
[task 2024-06-07T17:56:28.614Z] Suppressed 10655 warnings (10655 in non-user code).
[task 2024-06-07T17:56:28.614Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.614Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmp79m_vlx0/tmp1bx3jopz.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/localizer.cpp
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/localizer.cpp:56:3: warning: use range-based for loop instead [modernize-loop-convert]
[task 2024-06-07T17:56:28.614Z]   for (int i = 0; i < words.size(); i++) {
[task 2024-06-07T17:56:28.614Z]   ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]       (auto & i : words)
[task 2024-06-07T17:56:28.614Z] /builds/worker/checkouts/vcs/src/localizer.cpp:367:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-06-07T17:56:28.614Z]   QTranslator* translator = new QTranslator(this);
[task 2024-06-07T17:56:28.614Z]   ^~~~~~~~~~~
[task 2024-06-07T17:56:28.614Z]   auto
[task 2024-06-07T17:56:28.614Z] 12122 warnings generated.
[task 2024-06-07T17:56:28.614Z] Suppressed 12120 warnings (12120 in non-user code).
[task 2024-06-07T17:56:28.614Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-06-07T17:56:28.614Z] Writing fixes to /builds/worker/checkouts/vcs/.tmp/clang-tidy/shared-sources-report.yaml ...
[task 2024-06-07T17:56:28.614Z] + mkdir -p /builds/worker/artifacts/
[task 2024-06-07T17:56:28.614Z] + cp .tmp/clang-tidy/mozillavpn-sources-report.yaml .tmp/clang-tidy/shared-sources-report.yaml /builds/worker/artifacts/
[fetches 2024-06-07T17:56:28.614Z] removing /builds/worker/fetches
[fetches 2024-06-07T17:56:34.474Z] finished
[taskcluster 2024-06-07 17:56:34.893Z] === Task Finished ===
[taskcluster 2024-06-07 17:56:35.329Z] Successful task run with exit code: 0 completed in 430.802 seconds