Do not throw error on unexpected attr in prod. (#3959)

mozilla-services · Jan 30, 2018 · 2575e38 · 2575e38
1 parent ad18a99
commit 2575e38
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/shared/shot.js b/shared/shot.js
@@ -247,9 +247,15 @@ class AbstractShot {
       }
     }
 
+    let isProd = typeof process !== "undefined" && process.env.NODE_ENV === "production";
+
     for (let attr in attrs) {
       if (attr !== "clips" && attr !== "id" && this.REGULAR_ATTRS.indexOf(attr) === -1 && this.DEPRECATED_ATTRS.indexOf(attr) === -1) {
-        throw new Error("Unexpected attribute: " + attr);
+        if (isProd) {
+          console.warn("Unexpected attribute: " + attr);
+        } else {
+          throw new Error("Unexpected attribute: " + attr);
+        }
       } else if (attr === "id") {
         console.warn("passing id in attrs in AbstractShot constructor");
         console.trace();