This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Move the ESR check from bootstrap into webextension API #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
Aug 29, 2018
| runAt: "document_start" | ||
| return browser.experiments.screenshots.getUpdateChannel().then((channel) => { | ||
| return browser.tabs.get(tabId).then(tab => { | ||
| const downloadOnly = !historyEnabled || uploadDisabled || channel === 'esr' || tab.incognito; |
There was a problem hiding this comment.
Linter is complaining about those single quotes around esr.
chenba
reviewed
Aug 29, 2018
| @@ -0,0 +1,34 @@ | |||
| /* globals AppConstants */ | |||
There was a problem hiding this comment.
I think we need ExtensionAPI in the globals as well.
jaredhirsch
force-pushed
the
4802-esr-check-api
branch
from
9e074a6
to
7181c9e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4802.
Unfortunately, ESR 60 doesn't allow legacy extensions, so there's no way to test this works in that case. But you can set the debugger and see that it returns the correct channel if you test from nightly :-\