This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Check some prefs from the API, not from bootstrap #4810
Merged
+25
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianb
approved these changes
Aug 29, 2018
| // 'aurora' - deprecated aurora channel (still observed in dxr) | ||
| // 'default' - local builds from source | ||
| // 'nightly-try' - nightly Try builds (QA may occasionally need to test with these) | ||
| async getUpdateChannel() { |
There was a problem hiding this comment.
Do these all need to be async?
There was a problem hiding this comment.
Nope, I copied the examples a little too closely. Since experimental APIs extend the same base ExtensionAPI class as built-in APIs, and the async bit is definitely not required there, must not be required here, either.
jaredhirsch
force-pushed
the
4531-pref-check-api
branch
from
c8abe2b
to
59dd56d
Compare
…webextension API
jaredhirsch
force-pushed
the
4531-pref-check-api
branch
from
59dd56d
to
f152bb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the history enabled and upload-disabled checks from bootstrap into the API.
It might make sense to just check all the prefs in a single API call, but this works for now.
This commit fixes #4531, and depends on the two commits from PR #4809.