-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VS Code dev container configuration. #2857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sven for these improvements! Like you, I am not a VS Code expert, but I agree this is a nice improvement for devs using VS Code.
I do have one request to add a small docs section for VS Code on using the Dev Containers extension. Perhaps we can add a .vscode/extensions.json
file with a recommendations
field pointing to the Dev Containers extension as well (referencing something similar I remember as a dev for FxA)?
@biancadanforth I added some documentation and the recommendation for the dev container extension. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Made a couple of small suggestions on the docs. Thank you.
67e27da
to
9cbc31c
Compare
I found a bug in the configuration. Since the |
This PR adds a dev container configuration for VS Code. Features:
I'm not really an expert on VS Code, so it's possible there are better ways of setting this up. This configuration works well for me, though, and it might be useful for others as well.