Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ruff format & add VS Code devcontainer #122

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Switch to ruff format & add VS Code devcontainer #122

merged 1 commit into from
Jan 10, 2024

Conversation

relud
Copy link
Member

@relud relud commented Jan 5, 2024 •
edited
Loading

@relud relud requested a review from a team January 5, 2024 19:02
@relud relud force-pushed the devcontainer-and-ruff branch 2 times, most recently from 475cd57 to 9ebe1ba Compare January 5, 2024 19:11
@relud relud mentioned this pull request Jan 5, 2024
Merged
relud
relud commented Jan 6, 2024
View reviewed changes
Makefile Show resolved Hide resolved
biancadanforth
biancadanforth approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- had one question for you inline before merging about the Mac OS specific issues we encountered with the devcontainer setup.

docs/dev.rst Outdated Show resolved Hide resolved
docs/dev.rst Show resolved Hide resolved
biancadanforth
biancadanforth reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@relud I hadn't tried make docs locally, but it's failing for a couple of reasons I mention in line (well one reason willkg already mentioned).

Makefile Show resolved Hide resolved
docs/dev.rst Show resolved Hide resolved
relud
relud commented Jan 10, 2024
View reviewed changes
docs/dev.rst Show resolved Hide resolved
@relud relud merged commit 3fb3084 into main Jan 10, 2024
1 check passed
@relud relud deleted the devcontainer-and-ruff branch January 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biancadanforth biancadanforth biancadanforth approved these changes

@willkg willkg willkg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@relud @willkg @biancadanforth