Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1871345: Dev container improvements #2861

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

smarnach
Copy link
Contributor

This merges the two Docker Compose configuration files and sets the Docker build arguments in the Docker Compose configuration.

@smarnach smarnach requested a review from a team as a code owner December 21, 2023 12:25
@@ -2,6 +2,10 @@ FROM mcr.microsoft.com/devcontainers/python:3.11-bullseye@sha256:105bf6a63ab0252

WORKDIR /app

# Install Debian packages
RUN apt-get update && \
apt-get install -y ripgrep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i was missing this

@smarnach smarnach merged commit a87601d into main Dec 26, 2023
1 check passed
@smarnach smarnach deleted the dev-container-improvements branch December 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants