Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis failure when updating to Pytest 3.7.* #140

Closed
marco-c opened this issue Aug 27, 2018 · 2 comments
Closed

Travis failure when updating to Pytest 3.7.* #140

marco-c opened this issue Aug 27, 2018 · 2 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Aug 27, 2018

E.g. #139

The error is:

Traceback (most recent call last):
  File "/opt/python/3.6.3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/python/3.6.3/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pytest.py", line 10, in <module>
    from _pytest.fixtures import fixture, yield_fixture
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/fixtures.py", line 17, in <module>
    from _pytest import nodes
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/nodes.py", line 11, in <module>
    from _pytest.mark.structures import NodeKeywords, MarkInfo
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/mark/__init__.py", line 4, in <module>
    from .structures import (
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/mark/structures.py", line 306, in <module>
    class MarkInfo(object):
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/mark/structures.py", line 309, in MarkInfo
    _marks = attr.ib(converter=list)
TypeError: attrib() got an unexpected keyword argument 'converter'

Very similar to python-jsonschema/jsonschema#449, pytest-dev/pytest#3280, pytest-dev/pytest#3228.

@rhcu
Copy link
Collaborator

rhcu commented Aug 27, 2018

One of dependencies installed with pip uses attrs>=17.3.0 (can be found here: https://travis-ci.org/mozilla/coverage-crawler/builds/420972230#L471), while the solution that they suppose is to use attrs>=17.4.0. Probably, this can be handwritten in requirements.txt?

@marco-c
Copy link
Collaborator Author

marco-c commented Aug 27, 2018

Maybe yes. Can you try putting attrs==17.4.0 in test-requirements.txt, update pytest and submit a PR with these changes? Then we'll see if Travis is happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants