Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal attrs library to v17.4.0 #3228

Merged
merged 2 commits into from
Feb 17, 2018

Conversation

twmr
Copy link
Contributor

@twmr twmr commented Feb 15, 2018

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

@twmr twmr changed the title Update attr Update minimal attrs library to v17.4.0 Feb 15, 2018
@twmr twmr changed the base branch from master to features February 15, 2018 20:13
@feuillemorte feuillemorte requested review from nicoddemus and removed request for nicoddemus February 15, 2018 20:49
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Feb 15, 2018

can we additionally opt in to warnings from attrs for the test runs so we note such details earlier?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.639% when pulling 82cdc48 on thisch:update_attr into 063e2da on pytest-dev:features.

@nicoddemus
Copy link
Member

The unrelated failure in py37 has already been fixed on the latest features, so merging. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants