Add more APIs to manage extensions of environement #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carljm let me know what you think and if it can be merged into master. I think this PR is not really important for most people, but since extensions can be added, it should be possible to remove these extensions. |
|
If it is accepted, it would be nice to add a description of these two methods to documentation (http://mozilla.github.io/nunjucks/api.html#environment). Personally, I find these two methods very useful. |
|
@SamyPesse This looks fine to me. I agree that these methods should be documented. |
| getExtension | ||
| env.getExtension(name) | ||
| Get an extension named **name**. | ||
| {% endapi %} | ||
|
|
||
| {% api %} | ||
| hasExtension | ||
| env.hasExtension(name) | ||
| Return true if a custom extension named **name** as been added. |
|
LGTM ! |
|
Looks good, merging. |
carljm
added a commit
that referenced
this pull request
Sep 15, 2015
Add more APIs to manage extensions of environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is just adding 2 methods to the Environment class:
removeExtensionandhasExtension.I needed these methods for GitBook, where some “blocks” can be redefined and the previous nunjucks extension needs to be cleanup before.