-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more APIs to manage extensions of environement #512
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
240bd2b
Add method 'removeExtension'
SamyPesse 146a635
Add method hasExtension to environment
SamyPesse dc89bf9
Fix remove of extension by using lib function
SamyPesse c04cf88
Document removeExtension and hasExtension
SamyPesse aa52de0
Fix typo in docs/api.md
SamyPesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,7 +228,7 @@ env.addFilter(name, func, [async]) | |
|
||
Add a custom filter named **name** which calls **func** whenever | ||
invoked. If the filter needs to be async, **async** must be `true` | ||
(see [asynchronous support](#asynchronous-support)). See | ||
(see [asynchronous support](#asynchronous-support)). See | ||
[Custom Filters](#custom-filters). | ||
|
||
{% endapi %} | ||
|
@@ -249,12 +249,26 @@ See [Custom Tags](#custom-tags). | |
|
||
{% endapi %} | ||
|
||
{% api %} | ||
removeExtension | ||
env.removeExtension(name) | ||
|
||
Remove a previously added custom extension named **name** | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Period at the end of the sentence. |
||
|
||
{% endapi %} | ||
|
||
{% api %} | ||
getExtension | ||
env.getExtension(name) | ||
Get an extension named **name**. | ||
{% endapi %} | ||
|
||
{% api %} | ||
hasExtension | ||
env.hasExtension(name) | ||
Return true if a custom extension named **name** as been added. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/as/has/ |
||
{% endapi %} | ||
|
||
{% api %} | ||
addGlobal | ||
env.addGlobal(name, value) | ||
|
@@ -444,7 +458,7 @@ MyLoader.prototype.getSource = function(name) { | |
It can get a little more complex. If you want to track updates to | ||
templates and bust the internal cache so that you can see updates, you | ||
need to extend the `Loader` class. This gives you `emit` method that | ||
can fire events. You need to call it | ||
can fire events. You need to call it | ||
|
||
```js | ||
var MyLoader = nunjucks.Loader.extend({ | ||
|
@@ -453,7 +467,7 @@ var MyLoader = nunjucks.Loader.extend({ | |
// and call `this.emit('update', name)` when a template | ||
// is changed | ||
} | ||
|
||
getSource: function(name) { | ||
// load the template | ||
} | ||
|
@@ -474,7 +488,7 @@ asynchronously. | |
```js | ||
var MyLoader = nunjucks.Loader.extend({ | ||
async: true, | ||
|
||
getSource: function(name, callback) { | ||
// load the template | ||
// ... | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the blank line here and not in the other api blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
removeExtension
, I copied/paste the doc foraddExtension
, which contain blank line. ForhasExtension
, I copied the one fromgetExtension
, which doesn't contain blank lines.