PDFDoc() now detects argument type #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var stream = new Stream(data); | ||
| function constructor(arg, callback) { | ||
| // Stream argument | ||
| if (typeof arg.isStream !== 'undefined') { |
There was a problem hiding this comment.
should this be |typeof arg.isStream !== 'undefined' && arg.isStream| ?
There was a problem hiding this comment.
I suppose someone could really mess with us and add a isStream = false to an object... So, yep :)
Or more simply: if (arg.isStream). I just added typeof for consistency with the test below it (ArrayBuffer type).
There was a problem hiding this comment.
@cgjones I was just about to fix this :) oh well, I guess it's no biggie.
joneschrisg
added a commit
that referenced
this pull request
Sep 27, 2011
PDFDoc() now detects argument type
|
Let's merge it with your next pull request. |
stephanrauh
added a commit
to stephanrauh/pdf.js
that referenced
this pull request
Nov 25, 2020
stephanrauh
added a commit
to stephanrauh/pdf.js
that referenced
this pull request
Nov 26, 2020
stephanrauh
added a commit
to stephanrauh/pdf.js
that referenced
this pull request
Nov 26, 2020
stephanrauh
added a commit
to stephanrauh/pdf.js
that referenced
this pull request
Nov 26, 2020
…ge (but only when pageMode="single")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion with @angreasgal in #532,
PDFDoc()now detects whether the argument isArrayBuffer()or our ownStream(), and initializes accordingly.