Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused isStream property on various Streams #8016

Merged
merged 1 commit into from
Feb 1, 2017
Merged

Remove the unused isStream property on various Streams #8016

merged 1 commit into from
Feb 1, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

This property was added all the way back in PR #542, but hasn't actually been relied upon ever since PR #692.
Note that there's a isStream() utility function which replaced the property years ago, hence the isStream property is now dead code.

This property was added all the way back in PR 542, but hasn't actually been relied upon ever since PR 692.
Note that there's a `isStream()` utility function which replaced the property years ago, hence the `isStream` property is now dead code.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/375e949bd716e6a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1feb30079001e83/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1feb30079001e83/output.txt

Total script time: 25.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/375e949bd716e6a/output.txt

Total script time: 25.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5cc7ad85df492d7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5cc7ad85df492d7/output.txt

Total script time: 2.28 mins

Published

@timvandermeij timvandermeij merged commit fe3b64d into mozilla:master Feb 1, 2017
@timvandermeij
Copy link
Contributor

Thank you for the cleanup!

@Snuffleupagus Snuffleupagus deleted the remove-isStream-property branch February 2, 2017 11:44
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…operty

Remove the unused `isStream` property on various `Stream`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants