Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. follow-up fixes to PR 6299 (Convert canvas thumbnails to PNG) #6441

Merged
merged 3 commits into from
Sep 11, 2015
Merged

Misc. follow-up fixes to PR 6299 (Convert canvas thumbnails to PNG) #6441

merged 3 commits into from
Sep 11, 2015

Commits on Sep 11, 2015

  1. Extract the conversion from canvas to image into a helper functio… 

    …n in `PDFThumbnailView`

*Follow-up to PR 6299.*

This patch reduces unnecessary code duplication for the `canvas` to `image` conversion. It also does a bit of re-ordering (and adds new lines) in `_getPageDrawContext`, since that function currently is a bit hard to read.
    @Snuffleupagus
    Snuffleupagus committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    ebce928 View commit details
    Browse the repository at this point in the history

  2. Prevent setImage from failing to display small thumbnails, by addin… 

    …g a missing `canvas` to `image` conversion

*Follow-up to PR 6299.*
    @Snuffleupagus
    Snuffleupagus committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    555c792 View commit details
    Browse the repository at this point in the history

  3. Delete, and clear, the image in PDFThumbnailView_reset 

    *Follow-up to PR 6299.*
    @Snuffleupagus
    Snuffleupagus committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    d7a90d8 View commit details
    Browse the repository at this point in the history