Misc. follow-up fixes to PR 6299 (Convert canvas thumbnails to PNG) #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in `PDFThumbnailView` *Follow-up to PR 6299.* This patch reduces unnecessary code duplication for the `canvas` to `image` conversion. It also does a bit of re-ordering (and adds new lines) in `_getPageDrawContext`, since that function currently is a bit hard to read.
…g a missing `canvas` to `image` conversion *Follow-up to PR 6299.*
*Follow-up to PR 6299.*
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e381ae5e027a25b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e381ae5e027a25b/output.txt Total script time: 1.07 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Sep 11, 2015
Misc. follow-up fixes to PR 6299 (Convert canvas thumbnails to PNG)
|
Thank you for this follow-up and sorry for not having seen the missing convert statement! Looks much better this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #6299.
Please refer to the individual commit messages for detailed information.
@timvandermeij Can you please review this? Since we're getting close to next Firefox release, it would be good to get this fixed now to avoid having to uplift patches manually.
Even with these patches, there are still some visual glitches (from #6299) present. Below is an illustration of what things looks like before thumbnails are rendered (note the small empty rectangles). This seems to be an issue related to the fact that you cannot set the
width/heightof an emptyimage(as opposed to acanvas).I know how I'd like to fix this, but since that might require some discussion regarding the implementation, I wanted to submit the current PR to address the most important breakage first.