Web worker integration. #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oesnt have a document to attach the canvas to
…tform + has no mask
…ttern as toIR is called all the time
| var w = imgData.width; | ||
| var h = imgData.height; | ||
| // scale the image to the unit square | ||
| ctx.scale(1 / w, -1 / h); |
There was a problem hiding this comment.
Add a few line spaces where it makes sense? They are free! :)
The thing is, that the new code base make an early decision depending on if the object has an The |
| return null; | ||
| }; | ||
| constructor.shadingFromIR = function pattern_shadingFromIR(ctx, raw) { | ||
| var obj = window[raw[0]]; |
There was a problem hiding this comment.
TODO: Julian, can you please fix this hack? We thought of adding a switch but we don't know the possible class names. This might need to be conceptually revisited, not sure.
|
@pdfjsbot test |
|
Processing command test by user brendandahl. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/2487205.txt [bot:processed:2487205] |
|
ERROR(s) found Output: Bot response time: 29.94 mins |
| startIdx = gfx.executeIRQueue(IRQueue, startIdx, next); | ||
| if (startIdx == length) { | ||
| self.stats.render = Date.now(); | ||
| if (callback) callback(); |
There was a problem hiding this comment.
Not a problem but I usually prefer to this kind of expression in 2 lines.
|
I have a few other nits but nothing that can't be fixed later. The architecture of all this is going to change later but this work will be tracked in #issue 690, let's push the f**** button! congrats guys! |
vingtetun
added a commit
that referenced
this pull request
Oct 21, 2011
Web worker integration (disabled by default)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges all of Julian's web worker code from pull request #635. Some notable things:
See and use #690 for further discussion on ideas to streamline this code. Use this issue if you see anything you really don't want do go into master.
And of course a huge thanks to Julian for doing this!