[PDFThumbnailView] Re-factor the canvas to image conversion such that we always render to a canvas, and then replace it with an image once rendering is done
#7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
canvas to image conversion such that we always render to a canvas, and then replace it with an image once rendering is donecanvas to image conversion such that we always render to a canvas, and then replace it with an image once rendering is done
…that we always render to a `canvas`, and then replace it with an `image` once rendering is done *This is a follow-up to PRs 6299 and 6441.* The patch also adds an option to `PDFThumbnailView`, that disables the canvas-to-image conversion entirely, which might be useful in the context of issue 7026.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cae578a0bbdb086/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cae578a0bbdb086/output.txt Total script time: 0.87 mins Published |
yurydelendik
added a commit
that referenced
this pull request
Mar 7, 2016
…canvas-to-image [PDFThumbnailView] Re-factor the `canvas` to `image` conversion such that we always render to a `canvas`, and then replace it with an `image` once rendering is done
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PRs #6299 and #6441.
The patch also adds an option to
PDFThumbnailView, that disables the canvas-to-image conversion entirely, which might be useful in the context of issue #7026.