-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Array.isArray in the LoopbackPort. #8813
Conversation
Can we use For IE9, a polyfill can be added to compatibility.js. |
Indeed, wouldn't just changing https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L1097 suffice so it's immediately used everywhere? For the polyfill we can use |
Maybe. There are too many places to check if they will work as expected when changed. For now I'm just addressing regression (and hope will not add another one :). |
Per MDN, Array.isArray is implemented in IE9 |
Even better. Then we don't need a polyfill at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but it now needs a rebase :-)
r=me, with passing tests.
28836ba
to
438c0b2
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2c396b7034ac963/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4b9d5b098bdaf77/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2c396b7034ac963/output.txt Total script time: 16.47 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/4b9d5b098bdaf77/output.txt Total script time: 29.25 mins
|
Use Array.isArray in the LoopbackPort.
For better serialization of Arrays that belong to different sandboxes.
See also http://logs.glob.uno/?c=mozilla%23pdfjs#c66373
/cc @tobytailor