Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the isArray helper function with the native Array.isArray function #8864

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Replace the isArray helper function with the native Array.isArray function #8864

merged 1 commit into from
Sep 1, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

Follow-up to PR #8813.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/0e5e30b988971c7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2e4907fc47e58d2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/0e5e30b988971c7/output.txt

Total script time: 29.27 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/0e5e30b988971c7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/2e4907fc47e58d2/output.txt

Total script time: 60.00 mins

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c48ae95366e6129/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2017

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/c48ae95366e6129/output.txt

Total script time: 16.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 336d26d into mozilla:master Sep 1, 2017
@timvandermeij
Copy link
Contributor

Nice, thank you!

@Snuffleupagus Snuffleupagus deleted the rm-isArray branch September 2, 2017 07:15
@Snuffleupagus Snuffleupagus mentioned this pull request Jul 9, 2018
Merged
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@timvandermeij
Merge pull request mozilla#8864 from Snuffleupagus/rm-isArray
a382045 
Replace the `isArray` helper function with the native `Array.isArray` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij