Build with Gradle #179

eshepelyuk · 2015-04-26T13:04:14Z

MIgration of build system to Gradle.
Some unit tests were modified, 1 unused was deleted to make Gradle adoption easier.
fixes #178 fixes #168

Closes #57

Done

usage of Gradle wrapper, no local Gradle installation needed
compile sources and tests with Gradle
run unit tests and benchmark testing
publishing to Maven compatible repositories with Gradle
legacy Ant and Maven scripts are still working
support of quick import from IDE, especially IntelliJ IDEA due to Gradle project nature

Postponed for further review, until PR approval

code structure reorganization
deletion of legacy scripts
README updates
usage of default build directory, now custom folder buildGradle is used to prevent conflicts with Ant

Not planned

creating ZIP artifacts like one currently produced by Ant. It seems no need to have one
release management, i.e. automatic version update, creating GIT tags etc
EMMA test code coverage

+ sources and test compilation + jar building

- disabled test removed

+ run benchmark from Gradle + publishing artifacts from Gradle

This reverts commit 4c8018e.

eshepelyuk · 2015-04-26T13:09:15Z

Hello @gbrail, could you review the PR and provide your feedback.
Thnx in advance.

+ exclude unnecesary files from jar

gbrail · 2015-04-29T15:58:50Z

Working on testing this -- I hope to get more time next week.

Can you try and figure out why I have to put a bunch of Maven stuff in my global "gradle.properties," including a repo URL, username, and password? I think that if we want everybody to use this (and we do) then they shouldn't have to configure that stuff. I can give details if you want...

eshepelyuk · 2015-04-29T16:19:45Z

Hello,
That's the thing I've missed to describe. You're right - there's no need to put those properties into gradle.properties of root folder.

Just create a file ${HOME}/.gradle/gradle.properties and put repository URLs and credentials properties there. This is how it is intended to work.

I'll update README.md with Gradle related changes soon.

gbrail · 2015-04-29T16:32:48Z

Is there a way to write the Gradle files so that those properties are
optional? Most people building this product won't have those.

On Wed, Apr 29, 2015 at 9:19 AM, Evgeny Shepelyuk notifications@github.com
wrote:

Hello,
That's the thing I've missed to describe. You're right - there's no need
to put those properties into gradle.properties of root folder.

Just create a file ${HOME}/.gradle/gradle.properties and put repository
URLs and credentials properties there. This is how it is intended to work.

I'll update README.md with Gradle related changes soon.

—
Reply to this email directly or view it on GitHub
#179 (comment).

greg brail | apigee https://apigee.com/ | twitter @gbrail
http://twitter.com/gbrail

eshepelyuk · 2015-04-29T16:40:03Z

Pushed the fix, plz update.

gbrail · 2015-05-01T01:36:07Z

Making good progress...

I think that there are two more things we should do:

First, of all the "compile" ant task (on line 43 of build.xml) copies all the source into the build directory before compiling, and uses an ant "filter" task to replace the macro @IMPLEMENTATION-VERSION

gbrail · 2015-05-01T01:40:01Z

...

First, of all the "compile" ant task (on line 43 of build.xml) copies all the source into the build directory before compiling, and uses an ant "filter" task to replace the macro @IMPLEMENTATION-VERSION@ with the version from build.properties. Without doing this macro replacement, then you get this:

$ java -jar buildGradle/libs/rhino-1.7.7-SNAPSHOT.jar
@IMPLEMENTATION.VERSION@
js>

Instead of:

Rhino 1.7.7 2015 04 30
js>

Gradle can do this -- or we can find a better way since it's just one property in one file (it could look it up from the JAR manifest I think). But either way we should do it.

Second, we have always distributed the result of "ant dist" on the Mozilla web site, so if we want to remove ant and put in gradle instead, then we should include the ZIP file that results from this command.

Also, it'd be nice if there was an equivalent of "ant junit-benchmarks". But that can come later.

If you can fix the IMPLEMENTATION.VERSION easily, then I think we should merge this. Then we can see about removing the ant stuff.

eshepelyuk · 2015-05-01T04:43:51Z

As I've mentioned in PR description, we can run benchmark tests with Gradle. Just try to run gradlew testBenchmark.
IMPLEMENTATION_VERSION will be fixed.
About zip archive, what is the purpose of distributing it ? Should it be published to Maven repo as artifact ? What should be the content of that file ? I just see no good reasons now to copy old ant behaviour since we could just zip jars produced for publishing to maven. Please give me some clues about this archive purpose.

P.S. I will be able to provide fixes only starting from Monday.

gbrail · 2015-05-01T16:34:47Z

OK -- no worries. I can do a few things to fix it. I don't like the way that we filter ALL the source anyway so I'm going to change it in ant and then in Gradle. No need to do anything until you hear from me.

eshepelyuk · 2015-05-01T17:06:37Z

Well, maybe if you can wait couple if days I will push those fixes. I am planning to do in in Java and remove it from build script responsibilities.

gbrail · 2015-05-01T18:29:25Z

Of course, and we can take our time to get this right.

I made a small change and pushed it to a build called "greg-gradle." If you (having a lot more Gradle experience than I) think that it solves the immediate problem, then I think we can push this to master and then iterate from there.

Can you take a look:

https://github.com/mozilla/rhino/blob/greg-gradle/build.gradle

Basically, I added a task to copy the contents of "src/org/mozilla/javascript/resources" into the build directory, with filtering -- without that, the message property bundle was missing.

WIth this change, other than the "dist.zip" I think that we have Gradle doing everything that Ant did.

eshepelyuk · 2015-05-02T04:58:14Z

Looks good, not sure we need afterEvaluate closure.

eshepelyuk · 2015-05-03T12:19:19Z

Pushed fix to obtain Rhino display version from MANIFEST.MF and updated README to reflect Gradle related changes.
So, as soon as this PR will be merged, I will create new one with final cleanups, i.e. removing ant and maven scriots, restructuring source folders and using default build folder.

eshepelyuk · 2015-05-04T19:01:25Z

@gbrail have you ever expirienced failures in MozillaSuiteTest.
I see some tests are failing from time to time either running with Ant or Gradle.
But the failing tests are non permanent. They are failing just from time to time.

gbrail · 2015-05-04T19:55:31Z

Yes, there are a few tests that are timing-related. For instance, there is
one now that fails because it expects a certain performance characteristic
from global variables. It is not consistent. I'm not sure what to do about
these but we do have a few right now.

Interestingly, some of them perform differently when run via ant versus
gradle, which is especially strange.

On Mon, May 4, 2015 at 12:01 PM, Evgeny Shepelyuk notifications@github.com
wrote:

@gbrail https://github.com/gbrail have you ever expirienced failures in
MozillaSuiteTest.
I see some tests are failing from time to time either running with Ant or
Gradle.
But the failing tests are non permanent. They are failing just from time
to time.

—
Reply to this email directly or view it on GitHub
#179 (comment).

greg brail | apigee https://apigee.com/ | twitter @gbrail
http://twitter.com/gbrail

eshepelyuk · 2015-05-04T20:03:26Z

Gradle uses own tools for running JUnit and I've tried to emulate all the options from Ant build, we can't be confident that runners behave the same way.
Gradle uses some daemon process and caches when running build, so it could affect build
And last but not the least - Gradle should consume more PC resources on its own and it could affect GC cycles, thus affecting those tests.

gbrail · 2015-05-04T20:57:12Z

I am, however, seeing a null pointer exception in the re-factored
"ComplianceTest" that only happens when running on the CI machine, and not
locally:

http://ci.apigee.io/job/Mozilla%20Rhino%20Custom%20Branch/25/testReport/junit/org.mozilla.javascript.tests.commonjs.module/ComplianceTest/initializationError/

I'm not sure what's going on unless the directory that it's looking up in
line 34 doesn't exist or is not a directory.

On Mon, May 4, 2015 at 12:01 PM, Evgeny Shepelyuk notifications@github.com
wrote:

@gbrail https://github.com/gbrail have you ever expirienced failures in
MozillaSuiteTest.
I see some tests are failing from time to time either running with Ant or
Gradle.
But the failing tests are non permanent. They are failing just from time
to time.

—
Reply to this email directly or view it on GitHub
#179 (comment).

greg brail | apigee https://apigee.com/ | twitter @gbrail
http://twitter.com/gbrail

eshepelyuk · 2015-05-05T05:04:20Z

Could you check if files really exists in job's build folder ! I can't access it on my own.
Btw, the job still executes Ant, not Gradle. Is it intentional ?

eshepelyuk · 2015-05-05T11:34:27Z

I gave up struggling to create Pull Request to eshepelyuk-gradle branch with the possible fix.
So could you change CompianceTest line 34

from

final File[] files = new File(ComplianceTest.class.getResource("1.0").getPath()).listFiles();

to

final File[] files = new File("testsrc/org/mozilla/javascript/tests/commonjs/module/1.0").listFiles();

eshepelyuk · 2015-05-05T14:59:12Z

@gbrail Some more questions

Earlier I've asked about clarifications of the purpose of ZIP archive

About zip archive, what is the purpose of distributing it ?
Should it be published to Maven repo as artifact ? What should be the content of that file ?
I just see no good reasons now to copy old ant behaviour since we could just zip jars produced for publishing to maven.
Please give me some clues about this archive purpos
Do you mind including support for Spock testing framework to the project together with Gradle adoption ? Apparently with another PR, not current one.

gbrail · 2015-05-06T23:37:04Z

OK -- I fixed that and merged. Thanks for all the work on this!

eshepelyuk added 17 commits April 25, 2015 08:52

+ gradle wrapper

e750ac7

+ sources and test compilation + jar building

+ More JUnit style for Gradle compatibility

540778b

- disabled test removed

+ running tests

2caa1be

+ benchmark test changes for Gradle compaibility

7ffa859

+ run benchmark from Gradle + publishing artifacts from Gradle

+ benchmark test changes for Gradle compaibility

9a23c1b

+ run benchmark from Gradle + publishing artifacts from Gradle

+ publishing artifacts to maven compatible repositories

4c8018e

+ releasing with Gradle

d972b69

+ releasing with Gradle

d6c8d2d

+ releasing with Gradle

58542b4

+ releasing with Gradle

3314bdd

[Gradle Release Plugin] - new version commit: '1.7.8'.

4e8c41a

+ releasing with Gradle

a026771

+ releasing with Gradle

bd5cd34

+ releasing with Gradle

7defb07

[Gradle Release Plugin] - pre tag commit: '1.7.8'.

05f1e30

Revert "+ publishing artifacts to maven compatible repositories"

c7ce5d1

This reverts commit 4c8018e.

rollback gradle release

eb0fe82

eshepelyuk changed the title ~~Build with Gradle Resolves #178~~ Build with Gradle Apr 26, 2015

eshepelyuk added 2 commits April 26, 2015 16:38

+ properly populating manifest

89574c7

+ exclude unnecesary files from jar

+ adding license to jar

f49cb10

eshepelyuk mentioned this pull request Apr 28, 2015

Generated maven source file "rhino-1.7R3-sources.jar" does not contain org.mozilla.javascript.tools.* and others #20

Closed

+ build will not fail when maven credentials are not defined

330c0ed

+ getting rhino display version from MANIFEST

bf74fb5

eshepelyuk added 5 commits May 3, 2015 15:52

* modifying README with Gradle details

8efb4c6

Update README.md

323afa0

Improving reporting of MozillaSuiteTest tests

dbdef0d

Merge remote-tracking branch 'origin/gradle' into gradle

e2d17ac

Improving reporting of MozillaSuiteTest tests

df3f493

gbrail closed this May 6, 2015

eshepelyuk deleted the gradle branch May 7, 2015 07:01

eshepelyuk mentioned this pull request May 7, 2015

Implement build system with Gradle #178

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build with Gradle #179

Build with Gradle #179

eshepelyuk commented Apr 26, 2015

eshepelyuk commented Apr 26, 2015

gbrail commented Apr 29, 2015

eshepelyuk commented Apr 29, 2015

gbrail commented Apr 29, 2015

eshepelyuk commented Apr 29, 2015

gbrail commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 2, 2015

eshepelyuk commented May 3, 2015

eshepelyuk commented May 4, 2015

gbrail commented May 4, 2015

eshepelyuk commented May 4, 2015

gbrail commented May 4, 2015

eshepelyuk commented May 5, 2015

eshepelyuk commented May 5, 2015

eshepelyuk commented May 5, 2015

gbrail commented May 6, 2015

Build with Gradle #179

Build with Gradle #179

Conversation

eshepelyuk commented Apr 26, 2015

Done

Postponed for further review, until PR approval

Not planned

eshepelyuk commented Apr 26, 2015

gbrail commented Apr 29, 2015

eshepelyuk commented Apr 29, 2015

gbrail commented Apr 29, 2015

eshepelyuk commented Apr 29, 2015

gbrail commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 1, 2015

gbrail commented May 1, 2015

eshepelyuk commented May 2, 2015

eshepelyuk commented May 3, 2015

eshepelyuk commented May 4, 2015

gbrail commented May 4, 2015

eshepelyuk commented May 4, 2015

gbrail commented May 4, 2015

eshepelyuk commented May 5, 2015

eshepelyuk commented May 5, 2015

eshepelyuk commented May 5, 2015

gbrail commented May 6, 2015