Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven dependency and build management #57

Closed
wants to merge 2 commits into from
Closed

Conversation

anba
Copy link
Contributor

@anba anba commented Jul 4, 2012

I've created some Maven configuration files to build Rhino through Maven (in addition to Ant). The changes are meant to give users a drop-in replacement for Ant without requiring to apply any other Maven specific changes, such as, for example, switching to the Maven standard directory layout.

@pose
Copy link

pose commented Feb 24, 2013

👍

@sghill
Copy link
Contributor

sghill commented Mar 21, 2013

I like the idea of adding dependency management, but why not go for something a little more concise like gradle that uses maven under the hood?

@pose
Copy link

pose commented Mar 21, 2013

@sghill I don't have any issues as far as you provide an actually working patch

@sghill
Copy link
Contributor

sghill commented Mar 21, 2013

@pose Awesome.

Should we get a few of the pull requests sorted before changing the build system? The failing test on OS X in particular (issue #111) shook my confidence that I knew how to build rhino before trying it on fedora.

@pose
Copy link

pose commented Mar 21, 2013

(I'm not actually the maintainer of this repository, anyway. I was adding 👍 because I reviewed it)

@sghill
Copy link
Contributor

sghill commented Mar 21, 2013

Right, but you're a member of the Rhino community and that counts for
something :)

On Thu, Mar 21, 2013 at 8:50 AM, Alberto Pose notifications@gh.neting.ccwrote:

(I'm not actually the maintainer of this repository, anyway. I was adding [image:
👍] because I reviewed it)


Reply to this email directly or view it on GitHubhttps://github.com//pull/57#issuecomment-15246742
.

@pose
Copy link

pose commented Mar 21, 2013

Yes, I agree :)

@gbrail
Copy link
Collaborator

gbrail commented Jun 17, 2015

The current version of Rhino in master now supports building using Gradle. That has worked better than Maven because we are better able to support our legacy stuff.

@gbrail gbrail closed this Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants