Change Halstead implementation

[Luni-4]

In this way CodeMetrics is independent from lifetimes.

Thanks in advance for your review! :)

[codecov-commenter]

Codecov Report

Merging #224 into master will increase coverage by 0.52%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   16.76%   17.28%   +0.52%     
==========================================
  Files          46       46              
  Lines        5899     5918      +19     
  Branches      698      698              
==========================================
+ Hits          989     1023      +34     
+ Misses       4515     4493      -22     
- Partials      395      402       +7     

Impacted Files	Coverage Δ
src/metrics/cyclomatic.rs	43.85% <0.00%> (ø)
src/metrics/exit.rs	44.68% <0.00%> (ø)
src/metrics/fn_args.rs	71.42% <0.00%> (ø)
src/metrics/halstead.rs	38.88% <69.23%> (+7.38%)	⬆️
src/spaces.rs	59.18% <70.00%> (-1.11%)	⬇️
src/metrics/loc.rs	46.66% <100.00%> (ø)
src/metrics/mi.rs	60.00% <100.00%> (-4.71%)	⬇️
src/metrics/nom.rs	46.05% <100.00%> (ø)
rust-code-analysis-cli/src/web/server.rs	56.77% <0.00%> (+6.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf283d...fdcfd13. Read the comment docs.

[calixteman]

Could you make a PR with the tests only and then we can see if the refactoring doesn't introduce any regression ?

[Luni-4]

Could you make a PR with the tests only and then we can see if the refactoring doesn't introduce any regression ?

Yep, good idea, thanks! :)

[calixteman]

Please rebase.

[Luni-4]

The new finalize approach breaks the tests, it seems the Halstead is no more computed in the right way.

[Luni-4]

Now it works, I forgot to update the Mi implementation and stacks :P

[Luni-4]

@calixteman

Can we merge this PR, please?