Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dump formats code from lib to cli #230

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jun 30, 2020

This PR fixes #220

It should be merged after #224, #225, #226

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman June 30, 2020 16:04
@codecov-commenter
Copy link

Codecov Report

Merging #230 into master will increase coverage by 0.29%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   16.83%   17.13%   +0.29%     
==========================================
  Files          46       46              
  Lines        5873     5901      +28     
  Branches      696      698       +2     
==========================================
+ Hits          989     1011      +22     
- Misses       4484     4488       +4     
- Partials      400      402       +2     
Impacted Files Coverage Δ
rust-code-analysis-cli/src/formats.rs 0.00% <0.00%> (ø)
rust-code-analysis-cli/src/main.rs 0.00% <0.00%> (ø)
rust-code-analysis-cli/src/web/metrics.rs 36.00% <0.00%> (ø)
src/macros.rs 50.00% <0.00%> (-1.36%) ⬇️
src/metrics/cyclomatic.rs 43.85% <0.00%> (ø)
src/metrics/exit.rs 44.68% <0.00%> (ø)
src/metrics/fn_args.rs 69.69% <0.00%> (ø)
src/output/dump_metrics.rs 33.33% <0.00%> (ø)
src/metrics/halstead.rs 40.00% <65.90%> (+11.64%) ⬆️
src/spaces.rs 62.23% <69.44%> (+3.11%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d75c2d...7bd4ef8. Read the comment docs.

@Luni-4 Luni-4 force-pushed the move-formats branch 2 times, most recently from ac5043b to c17e003 Compare August 5, 2020 16:06
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Aug 5, 2020

This one is ready to be merged also

@calixteman calixteman merged commit b9c014c into mozilla:master Sep 14, 2020
@Luni-4 Luni-4 deleted the move-formats branch September 14, 2020 09:50
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the cli-specific dependencies to the cli subcrate
3 participants