Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Halstead tests #225

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jun 25, 2020

This PR adds tests for the Halstead metric.

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from calixteman June 25, 2020 15:02
@calixteman
Copy link
Collaborator

In the python code, could you add some inner functions:

def foo:
  def bar:
    def toto:...

with some common variables and not common ones to check that the merge stuff is ok too ? (things like a+b... to have some operands and operators)

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #225 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   16.83%   16.89%   +0.05%     
==========================================
  Files          46       46              
  Lines        5873     5879       +6     
  Branches      696      698       +2     
==========================================
+ Hits          989      993       +4     
  Misses       4484     4484              
- Partials      400      402       +2     
Impacted Files Coverage Δ
src/macros.rs 51.35% <ø> (ø)
src/metrics/halstead.rs 31.50% <66.66%> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d75c2d...c009440. Read the comment docs.

@calixteman calixteman merged commit 95b6e53 into mozilla:master Jul 2, 2020
@Luni-4 Luni-4 deleted the halstead-tests branch July 2, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants