Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not produce different files for each run on the mozilla-central repository #386

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Dec 1, 2020

When rust-code-analysis-cli was being run on the mozilla-central repository many times, the filenames of the output formats produced at each run were different. That was because the old code assigned filenames without considering that the thread scheduler picks up input files every time in a different order.

So, to avoid conflicts among files, we now use input file paths as output format filenames.

Thanks in advance for your review! :)

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #386 (a629b35) into master (5b58437) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   23.25%   23.27%   +0.01%     
==========================================
  Files          45       45              
  Lines        5491     5487       -4     
  Branches      805      805              
==========================================
  Hits         1277     1277              
+ Misses       3692     3688       -4     
  Partials      522      522              
Impacted Files Coverage Δ
rust-code-analysis-cli/src/formats.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b58437...a629b35. Read the comment docs.

@Luni-4 Luni-4 changed the title Do not produce different metrics for each run on the mozilla-central repository Do not produce different files for each run on the mozilla-central repository Dec 2, 2020
In this way, conflicts between the files of a tree are avoided
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer now

@Luni-4 Luni-4 merged commit 72eb2a6 into mozilla:master Dec 15, 2020
@Luni-4 Luni-4 deleted the fix-mc branch December 15, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants