Clean up filenames produced by rust-code-analysis-cli #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Dec 16, 2020
Luni-4
force-pushed
the
forgot-symbols
branch
2 times, most recently
from
cd7788b
to
4bc676c
Compare
Luni-4
changed the title
Luni-4
force-pushed
the
forgot-symbols
branch
from
8175eee
to
f263eba
Compare
Luni-4
changed the title
- Remove root - Remove current directory symbol - Avoid having duplicates filenames
Luni-4
force-pushed
the
forgot-symbols
branch
from
f263eba
to
1b2ec10
Compare
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 23.27% 23.26% -0.01%
==========================================
Files 45 45
Lines 5487 5489 +2
Branches 805 805
==========================================
Hits 1277 1277
- Misses 3688 3690 +2
Partials 522 522
Continue to review full report at Codecov.
|
marco-c
approved these changes
Dec 23, 2020
spacedragon
pushed a commit
to spacedragon/rust-code-analysis
that referenced
this pull request
Feb 2, 2021
- Remove root - Remove current directory symbol - Avoid having duplicates filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #386, when a path is cleaned up to create a new filename, the root and the current directory symbol haven't been removed, moreover some symbols lead to duplicates filenames. This PR fixes those problems.
Thanks in advance for your review! :)