Implement optimistic response for Tempo field updates #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu8n
force-pushed
the
optimistic-billing-update
branch
from
e8d2d74
to
5594d24
Compare
qu8n
changed the title
qu8n
force-pushed
the
optimistic-billing-update
branch
from
5594d24
to
32c9bb9
Compare
qu8n
commented
May 21, 2024
There was a problem hiding this comment.
This file contains the majority of new changes in this PR, but most changes are either (1) refactoring/moving code around to reduce code repeats and (2) adding missing types. There is one meaningful change that I'm going to highlight and comment on below.
qu8n
force-pushed
the
optimistic-billing-update
branch
from
7546b59
to
3208c07
Compare
ao508
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the optimistic update behavior for the Cohort Sample update workflow.
Before:
before.mp4
After:
after.mp4