Support case-insensitive search for all views #161
Conversation
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
8ef9ac3
to
fcefb0d
Compare
qu8n
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
qu8n
changed the title
qu8n
dismissed
ao508’s stale review
Removing this change request as we have discussed over Zoom. The new regex handles partial string matching and eliminates our need for _CONTAINS.
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
fcefb0d
to
3847c4c
Compare
qu8n
changed the title
Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
6e9a893
to
49f5c92
Compare
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
49f5c92
to
a6024b3
Compare
qu8n
changed the base branch from
dev-ignore-case-searching
to
dev-case-insensitive-search
There was a problem hiding this comment.
Replacing all instances of predicates _IN and _CONTAINS with _MATCHES. This lets us pass in a regex that enables both case-insensitive and partial string searches.
| const httpLink = createHttpLink({ | ||
| uri: "https://localhost:4000/graphql", | ||
| fetch: fetch, | ||
| }); | ||
|
|
||
| const client = new ApolloClient({ | ||
| link: httpLink, | ||
| cache: new InMemoryCache(), | ||
| }); | ||
|
|
There was a problem hiding this comment.
Removed as these are not being used. (These were used previously to query some samples data as part of the old sample mutation workflow.)
| filters: { | ||
| String: { | ||
| MATCHES: true, | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
FYI I removed ID: true inside of String: { ... }. That config would let us perform RegEx matching on values of type ID (source), which is a use case that we don't have.
There was a problem hiding this comment.
Isn't ID something we were interested in accessing?
There was a problem hiding this comment.
Yes, we are interested in accessing the ID, but setting ID: true here does something else. The docs link I shared above says it enables RegEx matching for value of type ID. For example, if we wanted to search for internal ID containing value "abc". Maybe I missed something there?
| filters: { | ||
| String: { | ||
| MATCHES: true, | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Isn't ID something we were interested in accessing?
For card #1263. This PR enables case-insensitive and partial string search for all views.
Example:
