Optimized sample dashboard query #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandawilson
commented
Sep 20, 2024
| qcCompleteStatus: mostRecentQcComplete | ||
| ? mostRecentQcComplete.properties.status | ||
| : null, | ||
| cohortsHasCohortSample: [], |
There was a problem hiding this comment.
Remove this if it is not needed.
mandawilson
commented
Sep 20, 2024
| @@ -31,6 +31,11 @@ import { | |||
| sortArrayByNestedField, | |||
| } from "../utils/flattening"; | |||
| import { ApolloServerContext } from "../utils/servers"; | |||
| import { | |||
There was a problem hiding this comment.
I don't think these are used now - I was just trying stuff.
| Query: { | ||
| // THIS ONE CAN BE CALLED FROM THE BROWSER | ||
| async sampleDashboardQuery( |
There was a problem hiding this comment.
I was calling this from the browser with the following, but in the code we use the above method. Don't leave both!
query ExampleQuery { sampleDashboardQuery { primaryId }}
| import { SortDirection } from "../generated/graphql"; | ||
| import { ApolloServerContext } from "./servers"; | ||
| //import { SamplesQueryResult } from "./dataloader"; | ||
| import { runQuery } from "../schemas/neo4j"; | ||
|
|
||
| const MAX_ROWS = 500; | ||
|
|
||
| export async function querySamplesList( | ||
| ogm: OGM, | ||
| where: GraphQLWhereArg, |
There was a problem hiding this comment.
I think we have the oncotree data here, we can use it to set cancerType and cancerTypeDetailed.
ao508
pushed a commit
that referenced
this pull request
Sep 30, 2024
Refactor the samples query to call Neo4j directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.