Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use lower case addresses, uncomment abis [skip ci] #60

Merged
merged 2 commits into from
Oct 21, 2022
Merged

chore: use lower case addresses, uncomment abis [skip ci] #60

merged 2 commits into from
Oct 21, 2022

Conversation

toniocodo
Copy link
Collaborator

@toniocodo toniocodo commented Oct 21, 2022 •
edited by doncesarts
Loading

  • Lowercase address for web npm package

@toniocodo toniocodo self-assigned this Oct 21, 2022
@doncesarts doncesarts merged commit 0860064 into develop Oct 21, 2022
@doncesarts doncesarts deleted the chore/update_web branch October 21, 2022 10:16
doncesarts added a commit that referenced this pull request Oct 21, 2022
@doncesarts @toniocodo @naddison36
chore: post deployment fixes (#63)
4a3355e 
* chore: use lower case addresses, uncomment abis [skip ci] (#60)

* chore: use lower case addresses, uncomment abis

* fix: undefined handling [skip ci]

* Fix initiation of CowSwap swaps (#61)

chore: 2nd security audit
fix: HH task liq-init-swap needs to set trader to CowSwapDex, not the Liquidator
fix: CowSwapDex initiateSwap takes fee off sell amount
chore: removed onlySign flag from CowSwap dex swap data
chore: removed SwapInitiated event from CowSwapSeller
chore: removes warning issues and updates liquidator tests (#62)
Co-authored-by: doncesarts <doncesarts@gmail.com>

Co-authored-by: Antoine Codogno <toniocodo@hotmail.com>
Co-authored-by: Nick Addison <nick@addisonbrown.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doncesarts doncesarts doncesarts approved these changes

@naddison36 naddison36 Awaiting requested review from naddison36

Assignees

@toniocodo toniocodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toniocodo @doncesarts