Issue/post deployment cesar #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doncesarts
commented
Oct 21, 2022
doncesarts
commented
- Fix liquidator unit tests
- Removes solhint warnings from interfaces related to curve , convex
naddison36
approved these changes
Oct 21, 2022
| sepolia, | ||
| polygon, | ||
| mumbai, | ||
| mainnet = 1, |
naddison36
pushed a commit
that referenced
this pull request
Oct 21, 2022
naddison36
added a commit
that referenced
this pull request
Oct 21, 2022
chore: 2nd security audit fix: HH task liq-init-swap needs to set trader to CowSwapDex, not the Liquidator fix: CowSwapDex initiateSwap takes fee off sell amount chore: removed onlySign flag from CowSwap dex swap data chore: removed SwapInitiated event from CowSwapSeller chore: removes warning issues and updates liquidator tests (#62) Co-authored-by: doncesarts <doncesarts@gmail.com>
doncesarts
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: use lower case addresses, uncomment abis [skip ci] (#60) * chore: use lower case addresses, uncomment abis * fix: undefined handling [skip ci] * Fix initiation of CowSwap swaps (#61) chore: 2nd security audit fix: HH task liq-init-swap needs to set trader to CowSwapDex, not the Liquidator fix: CowSwapDex initiateSwap takes fee off sell amount chore: removed onlySign flag from CowSwap dex swap data chore: removed SwapInitiated event from CowSwapSeller chore: removes warning issues and updates liquidator tests (#62) Co-authored-by: doncesarts <doncesarts@gmail.com> Co-authored-by: Antoine Codogno <toniocodo@hotmail.com> Co-authored-by: Nick Addison <nick@addisonbrown.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.